GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Lambda: add validations for PublishTo and inexistent capacity provider by anisaoshafi · Pull Request #13519 · localstack/localstack

This repository was archived by the owner on Mar 23, 2026. It is now read-only.

Conversation

@anisaoshafi

@anisaoshafi anisaoshafi commented Dec 12, 2025 •
edited by joe4dev
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Motivation

Add validations for PublishTo and inexistent capacity provider for Lambda Managed Instances.

Changes

Tests

Related

Closes DRG-298

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@anisaoshafi anisaoshafi added aws:lambda AWS Lambda semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Dec 12, 2025
@github-actions

github-actions Bot commented Dec 12, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Test Results - Preflight, Unit

23 046 tests  +45   21 201 ✅ +43   6m 9s ⏱️ -27s
     1 suites ± 0    1 845 💤 + 2 
     1 files   ± 0        0 ❌ ± 0 

Results for commit 20d4617. ± Comparison against base commit ee8518d.

This pull request removes 24 and adds 69 tests. Note that renamed tests count towards both. 
tests.unit.aws.test_connect.TestClientFactory ‑ test_typed_client_creation[iotanalytics]
tests.unit.aws.test_connect.TestClientFactory ‑ test_typed_client_creation[mediastore]
tests.unit.test_dns_server.TestDNSServer ‑ test_delete_operations_of_nonexistent_entries
tests.unit.test_dns_server.TestDNSServer ‑ test_dns_server_add_alias_lifecycle_with_ids
tests.unit.test_dns_server.TestDNSServer ‑ test_dns_server_add_host_lifecycle
tests.unit.test_dns_server.TestDNSServer ‑ test_dns_server_add_host_lifecycle_with_ids
tests.unit.test_dns_server.TestDNSServer ‑ test_dns_server_add_multiple_hosts
tests.unit.test_dns_server.TestDNSServer ‑ test_dns_server_alias_health_checks
tests.unit.test_dns_server.TestDNSServer ‑ test_dns_server_alias_lifecycle
tests.unit.test_dns_server.TestDNSServer ‑ test_dns_server_clear
…

tests.unit.aws.api.test_asf_providers ‑ test_provider_signatures[LogsProvider-LogsApi-cancel_import_task]
tests.unit.aws.api.test_asf_providers ‑ test_provider_signatures[LogsProvider-LogsApi-create_import_task]
tests.unit.aws.api.test_asf_providers ‑ test_provider_signatures[LogsProvider-LogsApi-describe_import_task_batches]
tests.unit.aws.api.test_asf_providers ‑ test_provider_signatures[LogsProvider-LogsApi-describe_import_tasks]
tests.unit.aws.protocol.test_op_router ‑ test_create_op_router_works_for_every_service[wickr]
tests.unit.aws.protocol.test_parser ‑ test_rpc_v2_cbor_timestamp_parsing
tests.unit.aws.test_service_router ‑ test_service_router_works_for_every_service[account-rest-json-GetGovCloudAccountInformation]
tests.unit.aws.test_service_router ‑ test_service_router_works_for_every_service[arc-region-switch-json-ListRoute53HealthChecksInRegion]
tests.unit.aws.test_service_router ‑ test_service_router_works_for_every_service[arc-region-switch-smithy-rpc-v2-cbor-ListRoute53HealthChecksInRegion]
tests.unit.aws.test_service_router ‑ test_service_router_works_for_every_service[artifact-rest-json-ListReportVersions]
…
This pull request removes 1 skipped test and adds 3 skipped tests. Note that renamed tests count towards both. 
tests.unit.test_dns_server.TestDNSServer ‑ test_dns_server_subdomain_of_route

tests.unit.aws.test_service_router ‑ test_service_router_works_for_every_service[bedrock-data-automation-rest-json-CopyBlueprintStage]
tests.unit.aws.test_service_router ‑ test_service_router_works_for_every_service[bedrock-data-automation-rest-json-GetBlueprintOptimizationStatus]
tests.unit.aws.test_service_router ‑ test_service_router_works_for_every_service[bedrock-data-automation-rest-json-InvokeBlueprintOptimizationAsync]

♻️ This comment has been updated with latest results.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Dec 12, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 4s ⏱️ -10s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 20d4617. ± Comparison against base commit ee8518d.

♻️ This comment has been updated with latest results.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Dec 12, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Test Results (amd64) - Integration, Bootstrap

    5 files  ±    0      5 suites  ±0   1h 59m 17s ⏱️ - 35m 8s
3 762 tests  - 1 759  3 478 ✅  - 1 487  284 💤  - 272  0 ❌ ±0 
3 768 runs   - 1 759  3 478 ✅  - 1 487  290 💤  - 272  0 ❌ ±0 

Results for commit 20d4617. ± Comparison against base commit ee8518d.

This pull request removes 1770 and adds 11 tests. Note that renamed tests count towards both. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

tests.aws.services.apigateway.test_apigateway_api.TestApiGatewayVpcLink ‑ test_create_vpc_link_invalid_parameters
tests.aws.services.apigateway.test_apigateway_api.TestApiGatewayVpcLink ‑ test_delete_vpc_link_invalid_id
tests.aws.services.apigateway.test_apigateway_api.TestApiGatewayVpcLink ‑ test_get_vpc_link_invalid_id
tests.aws.services.apigateway.test_apigateway_api.TestApiGatewayVpcLink ‑ test_update_vpc_link_invalid_id
tests.aws.services.apigateway.test_apigateway_api.TestApiGatewayVpcLink ‑ test_vpc_link_lifecycle
tests.aws.services.sns.test_sns.TestSNSTopicCrudV2 ‑ test_add_permission_errors
tests.aws.services.sns.test_sns.TestSNSTopicCrudV2 ‑ test_data_protection_policy_crud
tests.aws.services.sns.test_sns.TestSNSTopicCrudV2 ‑ test_remove_permission_errors
tests.aws.services.sns.test_sns.TestSNSTopicCrudV2 ‑ test_topic_add_multiple_permissions
tests.aws.services.sns.test_sns.TestSNSTopicCrudV2 ‑ test_topic_add_permission
…
This pull request removes 273 skipped tests and adds 1 skipped test. Note that renamed tests count towards both. 
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input4-FAILED]
tests.aws.scenario.mythical_mysfits.test_mythical_misfits.TestMythicalMisfitsScenario ‑ test_deployed_infra_state
tests.aws.scenario.mythical_mysfits.test_mythical_misfits.TestMythicalMisfitsScenario ‑ test_populate_data
tests.aws.scenario.mythical_mysfits.test_mythical_misfits.TestMythicalMisfitsScenario ‑ test_user_clicks_are_stored
tests.aws.services.cloudcontrol.test_cloudcontrol_api.TestCloudControlResourceApi ‑ test_api_exceptions
tests.aws.services.cloudcontrol.test_cloudcontrol_api.TestCloudControlResourceApi ‑ test_create_exceptions
tests.aws.services.cloudcontrol.test_cloudcontrol_api.TestCloudControlResourceApi ‑ test_create_invalid_desiredstate
tests.aws.services.cloudcontrol.test_cloudcontrol_api.TestCloudControlResourceApi ‑ test_double_create_with_client_token
tests.aws.services.cloudcontrol.test_cloudcontrol_api.TestCloudControlResourceApi ‑ test_lifecycle
…

tests.aws.services.sns.test_sns.TestSNSTopicCrudV2 ‑ test_data_protection_policy_crud

♻️ This comment has been updated with latest results.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Dec 12, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   1h 29m 53s ⏱️ - 24m 0s
3 738 tests  - 1 403  3 450 ✅  - 1 295  288 💤  - 108  0 ❌ ±0 
3 740 runs   - 1 403  3 450 ✅  - 1 295  290 💤  - 108  0 ❌ ±0 

Results for commit 20d4617. ± Comparison against base commit ee8518d.

This pull request removes 1414 and adds 11 tests. Note that renamed tests count towards both. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

tests.aws.services.apigateway.test_apigateway_api.TestApiGatewayVpcLink ‑ test_create_vpc_link_invalid_parameters
tests.aws.services.apigateway.test_apigateway_api.TestApiGatewayVpcLink ‑ test_delete_vpc_link_invalid_id
tests.aws.services.apigateway.test_apigateway_api.TestApiGatewayVpcLink ‑ test_get_vpc_link_invalid_id
tests.aws.services.apigateway.test_apigateway_api.TestApiGatewayVpcLink ‑ test_update_vpc_link_invalid_id
tests.aws.services.apigateway.test_apigateway_api.TestApiGatewayVpcLink ‑ test_vpc_link_lifecycle
tests.aws.services.sns.test_sns.TestSNSTopicCrudV2 ‑ test_add_permission_errors
tests.aws.services.sns.test_sns.TestSNSTopicCrudV2 ‑ test_data_protection_policy_crud
tests.aws.services.sns.test_sns.TestSNSTopicCrudV2 ‑ test_remove_permission_errors
tests.aws.services.sns.test_sns.TestSNSTopicCrudV2 ‑ test_topic_add_multiple_permissions
tests.aws.services.sns.test_sns.TestSNSTopicCrudV2 ‑ test_topic_add_permission
…
This pull request removes 109 skipped tests and adds 1 skipped test. Note that renamed tests count towards both. 
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input4-FAILED]
tests.aws.scenario.mythical_mysfits.test_mythical_misfits.TestMythicalMisfitsScenario ‑ test_deployed_infra_state
tests.aws.scenario.mythical_mysfits.test_mythical_misfits.TestMythicalMisfitsScenario ‑ test_populate_data
tests.aws.scenario.mythical_mysfits.test_mythical_misfits.TestMythicalMisfitsScenario ‑ test_user_clicks_are_stored
tests.aws.services.cloudcontrol.test_cloudcontrol_api.TestCloudControlResourceApi ‑ test_api_exceptions
tests.aws.services.cloudcontrol.test_cloudcontrol_api.TestCloudControlResourceApi ‑ test_create_exceptions
tests.aws.services.cloudcontrol.test_cloudcontrol_api.TestCloudControlResourceApi ‑ test_create_invalid_desiredstate
tests.aws.services.cloudcontrol.test_cloudcontrol_api.TestCloudControlResourceApi ‑ test_double_create_with_client_token
tests.aws.services.cloudcontrol.test_cloudcontrol_api.TestCloudControlResourceApi ‑ test_lifecycle
…

tests.aws.services.sns.test_sns.TestSNSTopicCrudV2 ‑ test_data_protection_policy_crud

♻️ This comment has been updated with latest results.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anisaoshafi
anisaoshafi force-pushed the lmi-validations branch 2 times, most recently from 316524e to 7ae8368 Compare December 12, 2025 23:30
@anisaoshafi
Lambda: add validations for PublishTo and inexistent capacity provider
d317f0f
@anisaoshafi
anisaoshafi force-pushed the lmi-validations branch from 7ae8368 to d317f0f Compare December 12, 2025 23:32
@anisaoshafi
anisaoshafi marked this pull request as ready for review December 13, 2025 13:09
@anisaoshafi
anisaoshafi requested review from dfangl, dominikschubert, gregfurman and joe4dev as code owners December 13, 2025 13:09
joe4dev
joe4dev approved these changes Dec 15, 2025
View reviewed changes
Comment thread localstack-core/localstack/services/lambda_/provider.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread localstack-core/localstack/services/lambda_/provider.py

if "CapacityProviderConfig" in request:
capacity_provider_config = request["CapacityProviderConfig"]
self._validate_capacity_provider_config(capacity_provider_config, context)

@joe4dev joe4dev Dec 15, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: nice catch 👏

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@anisaoshafi
Address nit
20d4617
@anisaoshafi
anisaoshafi merged commit 7900177 into main Dec 23, 2025
42 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@anisaoshafi
anisaoshafi deleted the lmi-validations branch December 23, 2025 11:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dominikschubert dominikschubert Awaiting requested review from dominikschubert
@dfangl dfangl Awaiting requested review from dfangl
@gregfurman gregfurman Awaiting requested review from gregfurman
1 more reviewer
@joe4dev joe4dev joe4dev approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

aws:lambda AWS Lambda docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@anisaoshafi @joe4dev
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.