GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — SQS: Complete implementation and testing of AWS::SQS:* CloudFormation resource providers by peter-smith-phd · Pull Request #13548 · localstack/localstack

This repository was archived by the owner on Mar 23, 2026. It is now read-only.

Conversation

@peter-smith-phd

@peter-smith-phd peter-smith-phd commented Dec 18, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Motivation

Complete implementation of the AWS::SQS::Queue, AWS::SQS::QueuePolicy and AWS::SQS::QueueInlinePolicy CloudFormation resources for SQS.

Changes

The changes can be reviewed in three different groups, which are mostly isolated from each other. If you prefer, I could create three separate PRs.

  • Anything with aws_sqs_queue in the name is related to AWS::SQS::Queue. These are very minor changes to adjust to the new generated subdirectory for auto-generated file.
  • Anything with aws_sqs_queuepolicy in the name is related to AWS::SQS::QueuePolicy. This is also a refactoring of file location, but also includes a bug fix to update.
  • Anything with aws_sqs_queueinlinepolicy in the name is related to AWS::SQS::QueueInlinePolicy. A full implementation of this resource type (there was no existing code for this).

Note that the .schema.json files are auto-downloaded from AWS, and therefore can't be hand-edited.

Tests

  • Extensive test cases to cover create/update/delete.

Related

https://linear.app/localstack/issue/ENG-162/enhance-cloudformation-test-cases-for-sqs-and-fix-bugs

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@peter-smith-phd peter-smith-phd added aws:sqs Amazon Simple Queue Service semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Dec 18, 2025
@github-actions

github-actions Bot commented Dec 18, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Test Results - Preflight, Unit

23 046 tests  ±0   21 201 ✅ ±0   6m 26s ⏱️ +39s
     1 suites ±0    1 845 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit da6932c. ± Comparison against base commit 3bcdd33.

♻️ This comment has been updated with latest results.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@peter-smith-phd
peter-smith-phd force-pushed the sqs/cfn-resources branch from 712e4fc to 4a98793 Compare December 18, 2025 23:17
@github-actions

github-actions Bot commented Dec 18, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   2m 57s ⏱️ -5s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit da6932c. ± Comparison against base commit 3bcdd33.

♻️ This comment has been updated with latest results.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Dec 18, 2025

Copy link
Copy Markdown

Test Results - Alternative Providers

583 tests   325 ✅  17m 49s ⏱️
  1 suites  258 💤
  1 files      0 ❌

Results for commit 4a98793.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Dec 19, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   1h 37m 0s ⏱️
3 557 tests 3 362 ✅ 195 💤 0 ❌
3 563 runs  3 362 ✅ 201 💤 0 ❌

Results for commit da6932c.

♻️ This comment has been updated with latest results.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Dec 19, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   1h 8m 28s ⏱️ - 46m 6s
3 533 tests  - 1 622  3 335 ✅  - 1 423  198 💤  - 199  0 ❌ ±0 
3 535 runs   - 1 622  3 335 ✅  - 1 423  200 💤  - 199  0 ❌ ±0 

Results for commit da6932c. ± Comparison against base commit 3bcdd33.

This pull request removes 1628 and adds 6 tests. Note that renamed tests count towards both. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

tests.aws.services.sqs.resource_providers.test_aws_sqs_queueinlinepolicy ‑ test_create_sqs_with_inlinepolicy
tests.aws.services.sqs.resource_providers.test_aws_sqs_queueinlinepolicy ‑ test_update_sqs_remove_inlinepolicy
tests.aws.services.sqs.resource_providers.test_aws_sqs_queueinlinepolicy ‑ test_update_sqs_with_inlinepolicy
tests.aws.services.sqs.resource_providers.test_aws_sqs_queuepolicy ‑ test_update_add_two_additional_queues_to_policy
tests.aws.services.sqs.resource_providers.test_aws_sqs_queuepolicy ‑ test_update_remove_two_queues_from_policy
tests.aws.services.sqs.resource_providers.test_aws_sqs_queuepolicy ‑ test_update_to_remove_queuepolicy_from_template

♻️ This comment has been updated with latest results.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@peter-smith-phd
peter-smith-phd force-pushed the sqs/cfn-resources branch from 4a98793 to fb26d82 Compare January 5, 2026 16:25
@peter-smith-phd
peter-smith-phd marked this pull request as ready for review January 5, 2026 17:12
@peter-smith-phd
peter-smith-phd requested review from baermat, gregfurman and thrau as code owners January 5, 2026 17:12
baermat
baermat suggested changes Jan 7, 2026
View reviewed changes

@baermat baermat left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me! There are 2 comments that seem to state incorrect information, otherwise we are good to go. Sorry for the late response, Christmas/New Year holiday :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread tests/aws/services/sqs/resource_providers/templates/sqs_without_queueinlinepolicy.yml
Comment on lines +1 to +3
#
# A standard SQS queue with an associated queue inline policy allowing a few actions.
#

@baermat baermat Jan 7, 2026

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a copy paste error, there is no associated policy as far as I can see unless I misunderstood something. Please adjust/remove the comment :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
peter-smith-phd reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread tests/aws/services/sqs/resource_providers/templates/sqs_without_queuepolicy.yml
Comment on lines +1 to +3
#
# A standard SQS queue with an associated queue policy allowing a few actions.
#

@baermat baermat Jan 7, 2026

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as before

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
peter-smith-phd reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
peter-smith-phd added 2 commits January 8, 2026 05:35
@peter-smith-phd
SQS: Complete implementation and testing of AWS::SQS:* CloudFormation…
e1869dc 
… resource providers.

# Conflicts:
#	localstack-core/localstack/services/sqs/resource_providers/aws_sqs_queuepolicy.py
@peter-smith-phd
Updates, as recommend in PR review.
da6932c
@peter-smith-phd
peter-smith-phd force-pushed the sqs/cfn-resources branch from fb26d82 to da6932c Compare January 7, 2026 16:36
@peter-smith-phd

peter-smith-phd commented Jan 7, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @baermat, I've made your suggested changes.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@peter-smith-phd
peter-smith-phd requested a review from baermat January 7, 2026 17:34
baermat
baermat approved these changes Jan 8, 2026
View reviewed changes
@peter-smith-phd
peter-smith-phd merged commit 3e92156 into main Jan 8, 2026
51 of 53 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@peter-smith-phd
peter-smith-phd deleted the sqs/cfn-resources branch January 8, 2026 15:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@thrau thrau Awaiting requested review from thrau
@gregfurman gregfurman Awaiting requested review from gregfurman
1 more reviewer
@baermat baermat baermat approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

aws:sqs Amazon Simple Queue Service docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@peter-smith-phd @baermat
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.