GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — APIGW: improve store typing by bentsku · Pull Request #13552 · localstack/localstack

This repository was archived by the owner on Mar 23, 2026. It is now read-only.

Conversation

@bentsku

@bentsku bentsku commented Dec 19, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Motivation

This PR improves the typing of the API Gateway store to remove imprecise typing.

Changes

  • set the types at the Class annotation level
  • use the generated APIs to type the store instead of plain dict

Tests

Related

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
giograno reacted with rocket emoji
All reactions
  • 🚀 1 reaction
@bentsku
fix APIGW store
89f8d8e
@bentsku bentsku added this to the 4.13 milestone Dec 19, 2025
@bentsku bentsku self-assigned this Dec 19, 2025
@bentsku bentsku added aws:apigateway Amazon API Gateway semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Dec 19, 2025
@github-actions

github-actions Bot commented Dec 19, 2025

Copy link
Copy Markdown

Test Results - Preflight, Unit

22 982 tests  ±0   21 140 ✅ ±0   6m 14s ⏱️ +13s
     1 suites ±0    1 842 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 89f8d8e. ± Comparison against base commit 056da83.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Dec 19, 2025

Copy link
Copy Markdown

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   19m 17s ⏱️ - 1h 37m 55s
1 315 tests  - 3 838  1 234 ✅  - 3 522  81 💤  - 316  0 ❌ ±0 
1 317 runs   - 3 838  1 234 ✅  - 3 522  83 💤  - 316  0 ❌ ±0 

Results for commit 89f8d8e. ± Comparison against base commit 056da83.

This pull request removes 3838 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Dec 19, 2025

Copy link
Copy Markdown

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 1s ⏱️ +12s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 89f8d8e. ± Comparison against base commit 056da83.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Dec 19, 2025

Copy link
Copy Markdown

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   36m 19s ⏱️
1 339 tests 1 259 ✅ 80 💤 0 ❌
1 345 runs  1 259 ✅ 86 💤 0 ❌

Results for commit 89f8d8e.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bentsku
bentsku marked this pull request as ready for review December 22, 2025 17:59
@bentsku
bentsku requested a review from cloutierMat as a code owner December 22, 2025 17:59
cloutierMat
cloutierMat approved these changes Dec 22, 2025
View reviewed changes

@cloutierMat cloutierMat left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 More Typing 🥳 Thanks @bentsku

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bentsku
bentsku merged commit 7f1e6b5 into main Dec 22, 2025
60 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bentsku
bentsku deleted the fix-apigw-store branch December 22, 2025 21:22
@bentsku bentsku mentioned this pull request Feb 4, 2026
APIGW: fix model typing / update custom id logic #13694
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@cloutierMat cloutierMat cloutierMat approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@bentsku bentsku

Labels

aws:apigateway Amazon API Gateway docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

4.13

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@bentsku @cloutierMat
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.