GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — use OUTBOUND_HTTP_PROXY for for external bypass client by cloutierMat · Pull Request #13565 · localstack/localstack

This repository was archived by the owner on Mar 23, 2026. It is now read-only.

Conversation

@cloutierMat

@cloutierMat cloutierMat commented Dec 23, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Motivation

When creating an ExternalBypassDnsClient, we should remain mindful of users proxy configurations and ensure that those external calls are respecting the Outbound Proxy configuration.

Changes

Ensure both the client and the http session are created with the user's http proxy configuration.

Tests

  • setup a local proxy.
  • start LocalStack with OUTBOUND_HTTP_PROXY and OUTBOUND_HTTPS_PROXY set to your proxies, configuration. It might be required also to set REQUESTS_CA_BUNDLE.
  • try to use the replicator to trigger the use of dns bypass client

Related

relates to UNC-146

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@github-actions

github-actions Bot commented Dec 24, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

S3 Image Test Results (AMD64 / ARM64)

    2 files      2 suites   7m 41s ⏱️
  552 tests   500 ✅  52 💤 0 ❌
1 104 runs  1 000 ✅ 104 💤 0 ❌

Results for commit 72fc81b.

♻️ This comment has been updated with latest results.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Dec 24, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Test Results - Preflight, Unit

23 046 tests  ±0   21 201 ✅ ±0   6m 11s ⏱️ -7s
     1 suites ±0    1 845 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 72fc81b. ± Comparison against base commit 3e92156.

♻️ This comment has been updated with latest results.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cloutierMat cloutierMat added semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes area: replicator labels Dec 24, 2025
@github-actions

github-actions Bot commented Dec 24, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 2s ⏱️ -3s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 72fc81b. ± Comparison against base commit 3e92156.

♻️ This comment has been updated with latest results.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Dec 24, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   2h 34m 43s ⏱️
5 569 tests 5 008 ✅ 561 💤 0 ❌
5 575 runs  5 008 ✅ 567 💤 0 ❌

Results for commit 72fc81b.

♻️ This comment has been updated with latest results.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Dec 24, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 57m 4s ⏱️ -5s
5 162 tests ±0  4 764 ✅ ±0  398 💤 ±0  0 ❌ ±0 
5 164 runs  ±0  4 764 ✅ ±0  400 💤 ±0  0 ❌ ±0 

Results for commit 72fc81b. ± Comparison against base commit 3e92156.

♻️ This comment has been updated with latest results.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cloutierMat
use OUTBOUND_HTTP_PROXY for for external bypass client
27d39af
@cloutierMat
cloutierMat force-pushed the replicator/use-outbound-proxy branch from c4aaa55 to 27d39af Compare January 8, 2026 18:37
@cloutierMat
cloutierMat marked this pull request as ready for review January 8, 2026 20:25
@cloutierMat
cloutierMat requested a review from thrau as a code owner January 8, 2026 20:25
@cloutierMat

cloutierMat commented Jan 8, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Test failure is addressed by #13599
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cloutierMat

cloutierMat commented Jan 8, 2026

Copy link
Copy Markdown
Contributor Author

Adding @simonrw, as original author of the DNS Bypass classes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cloutierMat
cloutierMat requested a review from simonrw January 8, 2026 20:31
simonrw
simonrw approved these changes Jan 10, 2026
View reviewed changes
Comment thread localstack-core/localstack/aws/connect.py Outdated
}
)
if config:
proxy_config = config.merge(proxy_config)

@simonrw simonrw Jan 10, 2026

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: it feels weird calling this the proxy config, maybe reassign the config variable?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@cloutierMat cloutierMat Jan 12, 2026

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that you point it out, you are right. I was trying to avoid using an extra if or else. I will make it a one liner in the super call. It actually reads better to me that way 👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@cloutierMat
pr comment
72fc81b
@cloutierMat
cloutierMat merged commit 1d67992 into main Jan 12, 2026
49 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@cloutierMat
cloutierMat deleted the replicator/use-outbound-proxy branch January 12, 2026 06:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@thrau thrau Awaiting requested review from thrau
1 more reviewer
@simonrw simonrw simonrw approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

area: replicator docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@cloutierMat @simonrw
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.