GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — IAM: Update `create_user_with_policy` fixture by aidehn · Pull Request #13568 · localstack/localstack

This repository was archived by the owner on Mar 23, 2026. It is now read-only.

Conversation

@aidehn

@aidehn aidehn commented Dec 29, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Description

  • Updates the create_user_with_policy to take a username - this helps with snapshot testing as sometimes the error will contain the username which you will want to know ahead of time.
  • Now waits for the user to be created before returning.
  • This change came up as a result of this POC PR: https://github.com/localstack/localstack-pro/pull/5719

Pro AWS Build Test and Push: https://github.com/localstack/localstack-pro/actions/runs/20571377274

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
viren-nadkarni reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@aidehn
update fixture to allow for username input and update to wait for use…
dad0b1f 
…r to be created
@github-actions

github-actions Bot commented Dec 29, 2025

Copy link
Copy Markdown

Test Results - Preflight, Unit

23 046 tests  ±0   21 201 ✅ ±0   6m 5s ⏱️ -15s
     1 suites ±0    1 845 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit dad0b1f. ± Comparison against base commit 2417384.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Dec 29, 2025

Copy link
Copy Markdown

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   2m 49s ⏱️ -5s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit dad0b1f. ± Comparison against base commit 2417384.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Dec 29, 2025

Copy link
Copy Markdown

Test Results (amd64) - Integration, Bootstrap

    5 files  ±0      5 suites  ±0   2h 35m 29s ⏱️ +33s
5 561 tests ±0  5 001 ✅ ±0  560 💤 ±0  0 ❌ ±0 
5 567 runs  ±0  5 001 ✅ ±0  566 💤 ±0  0 ❌ ±0 

Results for commit dad0b1f. ± Comparison against base commit 2417384.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Dec 29, 2025

Copy link
Copy Markdown

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 54m 40s ⏱️ +19s
5 154 tests ±0  4 757 ✅ ±0  397 💤 ±0  0 ❌ ±0 
5 156 runs  ±0  4 757 ✅ ±0  399 💤 ±0  0 ❌ ±0 

Results for commit dad0b1f. ± Comparison against base commit 2417384.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aidehn aidehn added semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Dec 29, 2025
@aidehn
aidehn requested review from dfangl, k-a-il, silv-io and viren-nadkarni December 29, 2025 10:35
@aidehn
aidehn marked this pull request as ready for review December 29, 2025 10:35
@aidehn
aidehn requested a review from dominikschubert as a code owner December 29, 2025 10:35
dfangl
dfangl approved these changes Dec 29, 2025
View reviewed changes

@dfangl dfangl left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think this is a safe change, however could you run the pro pipeline as well to make sure we don't miss anything, as this fixture is used in IAM tests in pro as well?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aidehn reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@aidehn

aidehn commented Dec 29, 2025

Copy link
Copy Markdown
Contributor Author

@dfangl Thanks for the quick review! For sure, I will run the Pro tests now 👍🏼
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aidehn
aidehn merged commit f8c65a0 into main Dec 29, 2025
61 of 64 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@aidehn
aidehn deleted the aidehn/update/create-user-with-policy branch December 29, 2025 13:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@viren-nadkarni viren-nadkarni Awaiting requested review from viren-nadkarni
@silv-io silv-io Awaiting requested review from silv-io
@k-a-il k-a-il Awaiting requested review from k-a-il
@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner
1 more reviewer
@dfangl dfangl dfangl approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@aidehn @dfangl
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.