GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(pyproject): Make inclusion of additional cfn schemas more permissive by gregfurman · Pull Request #13586 · localstack/localstack

This repository was archived by the owner on Mar 23, 2026. It is now read-only.

Conversation

@gregfurman

@gregfurman gregfurman commented Jan 6, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Motivation

With the addition of the resource_providers/generated subdirectory, we need to ensure the package data we include is more permissive schema data residing in subdirectories.

Related to #13534

Changes

  • Change pyproject.toml to include JSON schema data within recursive subdirectories of resource_providers

Tests

  • Manually tested this on my local by specifically targeting the commit SHA of this branch as a localstack dependency and validating that the generated/**/aws_sqs_queuepolicy.schema.json file is present i.e

    pip install git+https://github.com/localstack/localstack.git@3043c83fd5ccbc8e1a9216e46ae2e31b48c287e9
    
    test -f ".venv/lib/python3.13/site-packages/localstack/services/sqs/resource_providers/generated/aws_sqs_queuepolicy.schema.json" && echo "aws_sqs_queuepolicy.schema.json exists" || echo "aws_sqs_queuepolicy.schema.json does not exist"

Related

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@gregfurman
fix(pyproject): Make inclusion of additional cfn schemas more permissive
3043c83
@gregfurman gregfurman added this to the 4.13 milestone Jan 6, 2026
@gregfurman
gregfurman requested a review from simonrw January 6, 2026 13:50
@gregfurman gregfurman self-assigned this Jan 6, 2026
@gregfurman gregfurman added type: bug Bug report semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Jan 6, 2026
@github-actions

github-actions Bot commented Jan 6, 2026

Copy link
Copy Markdown

Test Results - Preflight, Unit

23 046 tests  ±0   21 201 ✅ ±0   6m 10s ⏱️ -2s
     1 suites ±0    1 845 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 3043c83. ± Comparison against base commit a9a6799.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions

github-actions Bot commented Jan 6, 2026

Copy link
Copy Markdown

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 55m 20s ⏱️ - 1m 59s
5 155 tests ±0  4 758 ✅ ±0  397 💤 ±0  0 ❌ ±0 
5 157 runs  ±0  4 758 ✅ ±0  399 💤 ±0  0 ❌ ±0 

Results for commit 3043c83. ± Comparison against base commit a9a6799.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@gregfurman
gregfurman marked this pull request as ready for review January 6, 2026 16:10
@gregfurman
gregfurman requested review from alexrashed, bentsku, k-a-il and silv-io as code owners January 6, 2026 16:10
peter-smith-phd
peter-smith-phd approved these changes Jan 6, 2026
View reviewed changes
@github-actions

github-actions Bot commented Jan 6, 2026

Copy link
Copy Markdown

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 0s ⏱️ -5s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 3043c83. ± Comparison against base commit a9a6799.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions

github-actions Bot commented Jan 6, 2026

Copy link
Copy Markdown

Test Results (amd64) - Integration, Bootstrap

    5 files  ±0      5 suites  ±0   2h 35m 39s ⏱️ -25s
5 562 tests ±0  5 002 ✅ ±0  560 💤 ±0  0 ❌ ±0 
5 568 runs  ±0  5 002 ✅ ±0  566 💤 ±0  0 ❌ ±0 

Results for commit 3043c83. ± Comparison against base commit a9a6799.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@gregfurman
gregfurman merged commit d027a58 into main Jan 6, 2026
80 of 83 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@gregfurman
gregfurman deleted the update/localstack-manifest-DRG-337 branch January 6, 2026 17:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@simonrw simonrw Awaiting requested review from simonrw
@alexrashed alexrashed Awaiting requested review from alexrashed alexrashed is a code owner
@silv-io silv-io Awaiting requested review from silv-io
@k-a-il k-a-il Awaiting requested review from k-a-il k-a-il is a code owner
@bentsku bentsku Awaiting requested review from bentsku
1 more reviewer
@peter-smith-phd peter-smith-phd peter-smith-phd approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@gregfurman gregfurman

Labels

docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases type: bug Bug report

Projects

None yet

Milestone

4.13

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@gregfurman @peter-smith-phd
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.