GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
GeezerVison is showing github.com — CloudFormation: Support nested intrinsic functions in Fn::FindInMap by nik-localstack · Pull Request #13678 · localstack/localstack
This repository was archived by the owner on Mar 23, 2026. It is now read-only.
Conversation
|
Test Results - Preflight, Unit23 088 tests ±0 21 229 ✅ ±0 6m 2s ⏱️ -20s Results for commit 3aefe4c. ± Comparison against base commit 39ec7cf. ♻️ This comment has been updated with latest results. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
LocalStack Community integration with Pro 2 files 2 suites 30m 53s ⏱️ Results for commit 3aefe4c. ♻️ This comment has been updated with latest results. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Test Results (amd64) - Acceptance7 tests ±0 5 ✅ ±0 3m 1s ⏱️ -2s Results for commit 3aefe4c. ± Comparison against base commit 39ec7cf. ♻️ This comment has been updated with latest results. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 43m 31s ⏱️ Results for commit 3aefe4c. ♻️ This comment has been updated with latest results. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Test Results - Alternative Providers585 tests 322 ✅ 17m 43s ⏱️ Results for commit 3aefe4c. ♻️ This comment has been updated with latest results. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Great PR. Thank you for fixing the issue and tackling a todo at the same time. I just have a minor comment for the last test.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| template_2 = { | ||
| "Parameters": { | ||
| "Environment": { | ||
| "Type": "String", | ||
| "Default": "dev", # Changed from "prod" | ||
| } | ||
| }, | ||
| "Mappings": { | ||
| "ComplexMap": { | ||
| "prod": {"aws": "prod-aws-value"}, | ||
| "dev": {"aws": "dev-aws-value"}, | ||
| } | ||
| }, | ||
| "Resources": { | ||
| "Topic1": { | ||
| "Type": "AWS::SNS::Topic", | ||
| "Properties": { | ||
| "TopicName": name1, | ||
| "DisplayName": { | ||
| "Fn::FindInMap": [ | ||
| "ComplexMap", | ||
| {"Ref": "Environment"}, | ||
| {"Ref": "AWS::Partition"}, | ||
| ] | ||
| }, | ||
| }, | ||
| } | ||
| }, | ||
| } | ||
|
|
||
| capture_update_process(snapshot, template_1, template_2) |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
comment: capture_update_process supports passing parameters, you could simply pass the environment as a parameter and save 30 lines of code. Unless you're really interested on testing the default parameter.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
52fba9e to
3aefe4c
Compare
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
bug: Redeploying an ARecord with CDK does not work when the Hosted Zone is created in another stack and retrieved with SSM Parameters
There was an error while loading. Please reload this page.