GeezerVison is showing github.com — tests: Fix pre-install fixtures logic by bentsku · Pull Request #13709 · localstack/localstack
This repository was archived by the owner on Mar 23, 2026. It is now read-only.
Conversation
bentsku
commented
Feb 6, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Motivation
Follow up from #13701, the fixture logic was wrong and I could not use early returns, because they were yield fixtures, aka generators. See https://docs.pytest.org/en/stable/how-to/fixtures.html#yield-fixtures-recommended
I've updated the fixture to not use yield anymore, allowing me to use early returns which makes more sense 👍
I've now tested properly the change and it works with no errors 👍 thanks @nik-localstack for surfacing this so quickly!
We got the following error before:
ValueError: opensearch did not yield a value Changes
- update the type of the fixtures by remove the
yield as they do not have any clean up logic, so that can use early return
Tests
Start LocalStack in an external container and run a test from each service like tests.aws.services.opensearch.test_opensearch.TestOpensearchProvider.test_list_versions and see that it works 👍
Related
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
nik-localstack reacted with rocket emoji
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to learn that you could not return from it, nice catch. LGTM
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
bentsku
commented
Feb 6, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
LocalStack Community integration with Pro
2 files ± 0 2 suites ±0 10m 49s ⏱️ - 1h 47m 49s
73 tests - 5 123 56 ✅ - 4 789 17 💤 - 334 0 ❌ ±0
75 runs - 5 123 56 ✅ - 4 789 19 💤 - 334 0 ❌ ±0
Results for commit 44deaf2. ± Comparison against base commit 965a755.
This pull request removes 5123 tests.
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Test Results - Preflight, Unit
23 114 tests ±0 21 255 ✅ ±0 6m 16s ⏱️ -1s
1 suites ±0 1 859 💤 ±0
1 files ±0 0 ❌ ±0
Results for commit 44deaf2. ± Comparison against base commit 965a755.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Test Results (amd64) - Acceptance
7 tests ±0 5 ✅ ±0 3m 4s ⏱️ -3s
1 suites ±0 2 💤 ±0
1 files ±0 0 ❌ ±0
Results for commit 44deaf2. ± Comparison against base commit 965a755.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Test Results (amd64) - Integration, Bootstrap
5 files 5 suites 20m 19s ⏱️
97 tests 80 ✅ 17 💤 0 ❌
103 runs 80 ✅ 23 💤 0 ❌
Results for commit 44deaf2.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Labels
docs: skip
Pull request does not require documentation changes
notes: skip
Pull request does not have to be mentioned in the release notes
semver: patch
Non-breaking changes which can be included in patch releases
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|