GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Merge pull request #291 from jbgi/fix-groupby-perf · lovejavaee/functionaljava@353507b

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

core/src/main/java/fj/data
- List.java

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎core/src/main/java/fj/data/List.java‎`

Copy file name to clipboardExpand all lines: core/src/main/java/fj/data/List.java

+9-8Lines changed: 9 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -1398,14 +1398,15 @@ public final <B, C, D> TreeMap<B, D> groupBy(`
`1398`	`1398`	`final D groupingIdentity,`
`1399`	`1399`	`final F2<C, D, D> groupingAcc,`
`1400`	`1400`	`final Ord<B> keyOrd) {`
`1401`		`- return this.foldLeft((map, element) -> {`
`1402`		`- final B key = keyFunction.f(element);`
`1403`		`- final C value = valueFunction.f(element);`
`1404`		`- return map.set(key, map.get(key)`
`1405`		`- .map(existing -> groupingAcc.f(value, existing))`
`1406`		`- .orSome(groupingAcc.f(value, groupingIdentity)));`
`1407`		`- }, TreeMap.empty(keyOrd)`
`1408`		`- );`
	`1401`	`+ java.util.TreeMap<B, D> buffer = new java.util.TreeMap<>(keyOrd.toComparator());`
	`1402`	`+ foreachDoEffect(element -> {`
	`1403`	`+ final B key = keyFunction.f(element);`
	`1404`	`+ final C value = valueFunction.f(element);`
	`1405`	`+ buffer.put(key, buffer.containsKey(key)`
	`1406`	`+ ? groupingAcc.f(value, buffer.get(key))`
	`1407`	`+ : groupingAcc.f(value, groupingIdentity));`
	`1408`	`+ });`
	`1409`	`+ return TreeMap.fromMutableMap(keyOrd, buffer);`
`1409`	`1410`	`}`
`1410`	`1411`
`1411`	`1412`

0 commit comments

Comments

0 (0)

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.