GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Performance improvement: Use TypeCache instead of manual type iteration by theo-rapidfire · Pull Request #56 · mackysoft/Unity-SerializeReferenceExtensions

Conversation

@theo-rapidfire

@theo-rapidfire theo-rapidfire commented Mar 28, 2024

Copy link
Copy Markdown
Contributor

fix/use-type-cache

Description

The PropertyDrawerType cache generation had a performance bottleneck, which could be resolved by using Unity's TypeCache.

Performance before:

  1. Selecting Item A
    image
  2. Selecting Item B
    image

Performance after:

  1. Selecting Item A
    image
  2. Selecting Item B
    image

Changes made

  • Converted PropertyDrawerCache type detection to use TypeCache

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mackysoft reacted with eyes emoji
All reactions
  • 👀 1 reaction
@theo-rapidfire
Use TypeCache instead of manual type iteration
f7c1017 
fix/use-type-cache
@theo-rapidfire theo-rapidfire changed the title Use TypeCache instead of manual type iteration Performance improvement: Use TypeCache instead of manual type iteration Mar 29, 2024
@mackysoft
mackysoft merged commit 2b40c3d into mackysoft:main Apr 1, 2024
@mackysoft

mackysoft commented Apr 1, 2024

Copy link
Copy Markdown
Owner

Function confirmed. Thanks @theo-rapidfire !
theo-rapidfire reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@theo-rapidfire @mackysoft
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.