GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix app ID regex for init command by tonycuadra · Pull Request #93 · magic-script/magic-script-cli

Conversation

@tonycuadra

@tonycuadra tonycuadra commented Oct 15, 2019

Copy link
Copy Markdown
Contributor
  • Show error message when regex validation fails
  • Do not use case-insensitive regex for app ID (causes mismatch with mabu)
  • Remove redundant regex definitions and rely on common util functions
  • Fix lint errors

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Tony Cuadra
Fix app ID regex for init command
6ea56dc 
- Show error message when regex validation fails
- Do not use case-insensitive regex for app ID (causes mismatch with mabu)
- Remove redundant regex definitions and rely on common util functions
- Fix lint errors
@tonycuadra
tonycuadra requested review from grozdanov and kpiascik October 15, 2019 19:11
Tony Cuadra added 2 commits October 15, 2019 15:32
Tony Cuadra
Always return bool from util isValidXXX functions
218c409 
Returning an error string (as required by inquirer) is deceptive.
Instead, generate the error string where it is needed.
Tony Cuadra
Remove stray comments
50efa85
kpiascik
kpiascik approved these changes Oct 15, 2019
View reviewed changes
Tony Cuadra
Bump version number to 2.2.13
50ab439
@tonycuadra
tonycuadra merged commit d5008e4 into master Oct 15, 2019
@tonycuadra
tonycuadra deleted the appid-regex branch October 15, 2019 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kpiascik kpiascik kpiascik approved these changes
@grozdanov grozdanov Awaiting requested review from grozdanov

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@tonycuadra @kpiascik
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.