GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Reject BarrelList item indexes past the end by codewithfourtix · Pull Request #470 · mahmoud/boltons

Conversation

@codewithfourtix

@codewithfourtix codewithfourtix commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Index translation subtracts the final barrel's length even when no barrel contains the requested index. As a result, reading or deleting at len(value) can target an existing item. Keep the final relative index out of bounds so normal list errors apply.

Adds read, write, delete, pop, and insertion regressions.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@codewithfourtix
Reject BarrelList item indexes past the end
6482ed7 
Signed-off-by: Ali Zulfiqar <[email protected]>
@mahmoud

mahmoud commented Sep 7, 2026

Copy link
Copy Markdown
Owner

Superseded by #440, which predates this PR by five weeks and fixes the same _translate_index bound through the existing (None, None) sentinel, along with insert clamping and a pop empty-tail bug (benchmarks in #439). Thanks for the thorough test cases; the out-of-bounds coverage matched what landed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mahmoud mahmoud closed this Sep 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@codewithfourtix @mahmoud
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.