GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(docs): Integrations documentation by Geo52rey · Pull Request #66 · mailscript/mailscript-cli

Conversation

@Geo52rey

@Geo52rey Geo52rey commented Mar 25, 2021

Copy link
Copy Markdown
Contributor

Added documentation for both the Google Drive and Zoom Integrations.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Geo52rey
fix(docs): Integrations documentation
29c304f
@Geo52rey
Geo52rey requested a review from vaultec81 March 25, 2021 18:19
vaultec81
vaultec81 reviewed Mar 25, 2021
View reviewed changes

@vaultec81 vaultec81 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small suggestions here and there.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread docs/docs/cli/integrations.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread docs/docs/cli/integrations.md

### Setup

There is currently no easy way to setup the Zoom Integration and is not currently supported.

@vaultec81 vaultec81 Mar 25, 2021

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe replace this line with coming soon or similar?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@Geo52rey Geo52rey Mar 25, 2021

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is coming soon. Last I heard, there aren't plans on going further with it for the time being.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vaultec81 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@vaultec81 vaultec81 Mar 25, 2021

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So maybe just remove the mention of Zoom entirely if it not something the user can use.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@Geo52rey Geo52rey Mar 31, 2021

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is accessible thru the API tho

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@vaultec81 vaultec81 Mar 31, 2021

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Geo25rey I would suggest adding some mention of the API in that case otherwise it would appear like we are offering a feature that isn't quite ready yet. Better to not confuse the reader with this.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread docs/docs/cli/integrations.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread docs/docs/cli/integrations.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Geo52rey
fix(docs): Minor edits on integrations
a80d47c
@Geo52rey
Geo52rey requested a review from vaultec81 March 25, 2021 21:04
@Geo52rey Geo52rey mentioned this pull request Mar 25, 2021
Docs handlebars #68
Open
vaultec81
vaultec81 reviewed Apr 5, 2021
View reviewed changes
Comment thread docs/docs/cli/integrations.md

### Setup

There is currently no easy way to setup the Zoom Integration and is not currently supported.

@vaultec81 vaultec81 Apr 5, 2021

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My previous comment here is the only major thing that stands out. Maybe replace with coming soon?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vaultec81
vaultec81 force-pushed the main branch 2 times, most recently from d7a2e96 to 45d5ed4 Compare April 8, 2021 20:51

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@vaultec81 vaultec81 vaultec81 left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Geo52rey @vaultec81
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.