GeezerVison is showing github.com — build scripts update by lightmare · Pull Request #210 · mapnik/python-mapnik
Conversation
lightmare
commented
Aug 29, 2019
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Notable changes
setup.py reads environment variables MASON_ROOT and MAPNIK_CONFIG, which can be used to override these paths; defaults remained as beforesetup.py no longer calls bootstrap.sh; it must be explicitly called earlierbootstrap.sh no longer runs postgres, createdb etc.; database initialization has been moved to scripts/setup_postgres.sh- mason added as git submodule;
scripts/setup_mason.sh now tries to update submodule first; if that's not possible, falls back to downloading archive as before
TODO
- amend README Building from Mason section, add command
./bootstrap.sh
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Also don't run bootstrap.sh from setup.py, instead assume that Mason
and required packages have already been installed (with bootstrap.sh
or otherwise).
- git submodule update when needed
- remove unused var JOBS (it shouldn't be in "env" even if it were used,
because changing "env" vars invalidates cache)
- install clang from apt instead of mason
- try common workaround for distutils bugs, without branching
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.