GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Updates to configure pycairo if available by davenquinn · Pull Request #24 · mapnik/python-mapnik

Conversation

@davenquinn

@davenquinn davenquinn commented Jun 4, 2015

Copy link
Copy Markdown

The Mapnik core does not check to see if python cairo is importable as part of its
prebuild. Thus, the includes for pycairo (and the define HAVE_PYCAIRO) are not
part of the mapnik-config --cflags output. (In the Mapnik scons script, HAS_PYCAIRO=False
is set. This seems reasonable in general, if we are trying to separate python concerns
from the core software. But that means that there is no way to use pycairo from the python bindings if we want it. This adds a check to the setup to see if we can drag in pycairo.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
davenquinn and others added 3 commits June 4, 2015 02:04
@davenquinn
Fix thread-local variables to use cross-platform Boost version
0128869
@davenquinn
Added test to link pycairo if needed.
55de6d8
@davenquinn
Got rid of extra -mt specifier on boost-thread
e89d25c
@davenquinn
davenquinn force-pushed the setup-updates branch from a0bec9a to e89d25c Compare June 4, 2015 19:34
@springmeyer

springmeyer commented Jun 4, 2015

Copy link
Copy Markdown
Member

Thanks for working on this @davenquinn - definitely something that fell through the cracks in the split. Don't have the mindspace right now to review this method meaningfully but I will say that I wonder if we can rethink pycairo support such that it is not a compile time thing.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@davenquinn

davenquinn commented Jun 4, 2015

Copy link
Copy Markdown
Author

Yeah, it might be reasonable to just remove the HAVE_PYCAIRO checks in src completely and rely on whether the mapnik build was configured with Cairo. It seems like that probably wouldn't break anything (and might provide better results for people using cairocffi instead of pycairo).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@davenquinn
Merge branch 'master' of https://github.com/davenquinn/python-mapnik …
46c58e6 
…into setup-updates

* 'master' of https://github.com/davenquinn/python-mapnik:
  Fix thread-local variables to use cross-platform Boost version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@davenquinn @springmeyer
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.