GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||
GeezerVison is showing github.com — #1216 Pick candidate method with most specific return type by filiphr · Pull Request #2993 · mapstruct/mapstruct Conversation
|
|
Apparently i missed that one.. sorry. Hi ahead and merge
Op zo 4 sep. 2022 12:35 schreef Filip Hrisafov ***@***.***>:
… ***@***.**** commented on this pull request.
------------------------------
In
processor/src/test/java/org/mapstruct/ap/test/selection/resulttype/ErroneousAmbiguousMostSpecificResultTypeSelectingMapper.java
<#2993 (comment)>:
> +import org.mapstruct.Mapping;
+
+/**
+ * @author Filip Hrisafov
+ */
***@***.***
+public interface ErroneousAmbiguousMostSpecificResultTypeSelectingMapper {
+
+ @mapping( target = "apple", source = "fruit")
+ AppleFamily map(FruitFamily fruitFamily);
+
+ default GoldenDelicious toGolden(IsFruit fruit) {
+ return fruit != null ? new GoldenDelicious( fruit.getType() ) : null;
+ }
+
+ default Apple toApple1(IsFruit fruit) {
Did you check Issue2840Mapper as part of this PR?
—
Reply to this email directly, view it on GitHub
<#2993 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABPDEY42KEDVNXWVGUASMDDV4R3OBANCNFSM573LRIBA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
General mechanism LGTM. One question though.. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
Ambiguous mapping method but there is a more specific mapping
There was an error while loading. Please reload this page.