GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Avoid unnecessary unboxing of Boolean by prasanth08 · Pull Request #3003 · mapstruct/mapstruct

Conversation

@prasanth08

@prasanth08 prasanth08 commented Sep 1, 2022

Copy link
Copy Markdown
Contributor

Changed Boolean.valueOf() to Boolean.parseBoolean() - Boolean.valueOf() returns Boolean while the attributes in Options Class is boolean, Boolean.parseBoolean() returns boolean.
Changed Collections.sort() to List.sort() - Collections.sort() internally calls the List.sort().
Fix Java - doc

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
prasanth08 added 9 commits August 14, 2022 20:22
@prasanth08
Update Typos in java-doc
de048d8
@prasanth08
Merge branch 'mapstruct:main' into main
bcbb906
@prasanth08
Merge branch 'mapstruct:main' into main
4ea0b15
@prasanth08
Update Typos in java-doc
e3729e8
@prasanth08
Update link typo in java-doc
68986c7
@prasanth08
Fix link close tag in java-doc
238bb58
@prasanth08
Merge remote-tracking branch 'origin/main'
41043c1 
# Conflicts:
#	processor/src/main/java/org/mapstruct/ap/internal/conversion/AbstractJavaTimeToStringConversion.java
@prasanth08
Refactor - Avoid unnecessary unboxing, Use List.sort()
e9d70bd
@prasanth08
Follow coding standard
6598183
filiphr
filiphr requested changes Sep 2, 2022
View reviewed changes

@filiphr filiphr left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your changes are OK @prasanth08, only one small comment about one of the Javadocs.

Apart from that, can you please rebase this on top of main. I see that there are some conflicts

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread processor/src/main/java/org/mapstruct/ap/MappingProcessor.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
prasanth08 added 2 commits September 9, 2022 11:04
@prasanth08
Merge branch 'mapstruct:main' into main
20b642e
@prasanth08
Revert typo jav-doc "enrichments"
02e878e
@prasanth08
prasanth08 requested a review from filiphr September 9, 2022 15:36
@filiphr
filiphr merged commit d593afe into mapstruct:main Sep 12, 2022
@filiphr

filiphr commented Sep 12, 2022

Copy link
Copy Markdown
Member

Thanks @prasanth08
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@filiphr filiphr modified the milestones: 1.5.3, 1.6.0 Sep 26, 2022
@filiphr filiphr added the documentation label Sep 26, 2022
@filiphr filiphr added refactoring and removed documentation labels Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@filiphr filiphr Awaiting requested review from filiphr

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

refactoring

Projects

None yet

Milestone

1.6.0.Beta1

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@prasanth08 @filiphr
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.