GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||
GeezerVison is showing github.com — Add support for custom name in Spring stereotype annotations by jccampanero · Pull Request #3019 · mapstruct/mapstruct Conversation
|
|
This solution only covers one out of many options for the Try creating a check that walks the meta-annotation tree instead of something that only checks the top level annotation. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thank you very much for the feedback @Zegveld. I absolutely agree with you: I initially thought of including checks for Again, thank you very much for the feedback, and sorry for this first baby step. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Check the existence of the @component annotation across the full annotation hierarchy.
There was an error while loading. Please reload this page.
|
@Zegveld Sorry for the late reply. I have pushed some new changes. Per your suggestion, I tried to process the Please let me know what additional work needs to be done. Thank you very much. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
The implementation looks good @jccampanero. I only have some points regarding the tests.
I do not think that we should complicate them that much. Do we really need to test this entirely using this in the Spring context. I think that it is enough to what we are doing in SpringAnnotateWithMapperTest without the spring context testing. We could also simplify the mappers by not doing Mapper#uses and without extending from other mappers. We can have empty mappers for the tests.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
…ntext. Remove unnecessary line endings.
|
Thank you very much for the code review @filiphr, I appreciate it a lot. I updated the code with the changes you requested. Please let me know if any additional changes need to be made. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks a lot for your patience @jccampanero. We've integrated this into main. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thank you very much @filiphr. Please, on the contrary, thank you very much for your time and for allowing me to contribute to this wonderful library. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
@Mapper(componentModel = "spring") doesn't support custom name for Spring Service Annotation
There was an error while loading. Please reload this page.