GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — #3199 Add support for implicit conversion between java.time.LocalDate and java.time.LocalDateTime by Bragolgirith · Pull Request #3254 · mapstruct/mapstruct

Conversation

@Bragolgirith

@Bragolgirith Bragolgirith commented Apr 25, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fixes #3199

Took the liberty of creating a PR.
First time contributing to the project, so do tell if I've missed something!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Bragolgirith
mapstruct#3199 Add support for implicit conversion between java.time.…
d2cab51 
…LocalDate and java.time.LocalDateTime
filiphr
filiphr approved these changes Apr 26, 2023
View reviewed changes

@filiphr filiphr left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Bragolgirith. It looks good to me. I only have one small question

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread processor/src/main/java/org/mapstruct/ap/internal/conversion/Conversions.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Bragolgirith
mapstruct#3199 Minor comment fix
6cda3a3
@Bragolgirith

Bragolgirith commented Apr 29, 2023

Copy link
Copy Markdown
Contributor Author

Also, there were some CI workflow run failures last time, e.g.:

Could not transfer artifact ... (truncated) ... Connect to repo.maven.apache.org:443 [repo.maven.apache.org/146.75.28.215] failed: Connection timed out -> [Help 1]

These seem unrelated to the PR - maybe a one-time connectivity issue or a proxy configuration issue?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@filiphr

filiphr commented Apr 30, 2023

Copy link
Copy Markdown
Member

Thanks for your changes @Bragolgirith.

Also, there were some CI workflow run failures last time, e.g.:

Those are some recurring flaky errors we are getting on our CI. I ignore those errors. I'll merge this once the final build is done
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@filiphr
filiphr merged commit d3b4a16 into mapstruct:main May 1, 2023
@Bragolgirith
Bragolgirith deleted the support-implicit-conversion-localdatetime-localdate branch May 1, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@filiphr filiphr filiphr approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support for implicit conversion between java.time.LocalDate and java.time.LocalDateTime

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Bragolgirith @filiphr
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.