GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — #3126 Apply target this references in the BeanMappingMethod by filiphr · Pull Request #3281 · mapstruct/mapstruct

Conversation

@filiphr

@filiphr filiphr commented May 21, 2023

Copy link
Copy Markdown
Member

Fixes #3126

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@filiphr
mapstruct#3126 Apply target this references in the BeanMappingMethod
e8e04e2
@filiphr filiphr mentioned this pull request May 21, 2023
#3126: do not change source parameter name for subclassmappings #3128
Closed
Zegveld
Zegveld approved these changes May 24, 2023
View reviewed changes

@Zegveld Zegveld left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is indeed a lot better then my solution.

Looks good to me.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@filiphr
filiphr merged commit c2eed45 into mapstruct:main May 27, 2023
@filiphr

filiphr commented May 27, 2023

Copy link
Copy Markdown
Member Author

Thanks for the review @Zegveld
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@filiphr
filiphr deleted the 3126 branch May 27, 2023 09:17
@nickponomar

nickponomar commented Aug 17, 2023

Copy link
Copy Markdown

@filiphr thanks for the fix! Is it available in implementation("org.mapstruct:mapstruct:1.5.5.Final") ? How do I check what version it landed into?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@filiphr

filiphr commented Sep 10, 2023

Copy link
Copy Markdown
Member Author

@nickpnmrv you can check by looking at the fix version for the #3126 issue. The fix is not yet released. It will be in 1.6
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Zegveld Zegveld Zegveld approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

@SubclassMapping not working with @Mapping nested properties and target all

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@filiphr @nickponomar @Zegveld
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.