GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — simplified some expressions, redundant expressions removed by anton-erofeev · Pull Request #3292 · mapstruct/mapstruct

Conversation

@anton-erofeev

@anton-erofeev anton-erofeev commented May 29, 2023

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@anton-erofeev
simplified some expressions, redundant expressions removed
3cae7c7
filiphr
filiphr requested changes Jun 16, 2023
View reviewed changes

@filiphr filiphr left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this cleanups @anton-erofeev. I only have one small remark, see my comment

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread processor/src/main/java/org/mapstruct/ap/internal/model/BeanMappingMethod.java Outdated
Comment on lines +501 to +500
for (Iterator<? extends TypeMirror> iterator = unusedPermittedSubclasses.iterator();
iterator.hasNext(); ) {
if ( ctx.getTypeUtils().isSameType( iterator.next(), subClassOption.getSource() ) ) {
iterator.remove();
}
}
unusedPermittedSubclasses.removeIf(
typeMirror -> ctx.getTypeUtils().isSameType(typeMirror, subClassOption.getSource()));

@filiphr filiphr Jun 16, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like this change because it means that a new anonymous class has to be created to capture the subClassOption. I prefer not to create new objects for things like this

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@anton-erofeev anton-erofeev Jun 19, 2023

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I reverted this change, thanks

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@anton-erofeev
reverted usage of 'removeIf' in BeanMappingMethod.java
cca864f
@anton-erofeev
anton-erofeev force-pushed the refactoring branch from c0a94f0 to cca864f Compare June 19, 2023 11:48
@anton-erofeev
anton-erofeev requested a review from filiphr June 20, 2023 07:40
@filiphr

filiphr commented Jul 8, 2023

Copy link
Copy Markdown
Member

@anton-erofeev seems like there are some formatting issues. Can you have a look at it please?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anton-erofeev
fixed codestyle issues
a133bc2
@anton-erofeev

anton-erofeev commented Jul 19, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

@anton-erofeev seems like there are some formatting issues. Can you have a look at it please?

updated but it looks like I can't run checks
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@filiphr

filiphr commented Jul 29, 2023

Copy link
Copy Markdown
Member

You are contributing for the first time @anton-erofeev and that's why the checks don't run automatically. I need to approve them in order for them to run. Just did that, if everything is OK, we'll merge this. For your next contributions this won't be necessary.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
filiphr
filiphr reviewed Aug 1, 2023
View reviewed changes
Comment thread processor/src/test/java/org/mapstruct/ap/test/nestedbeans/HouseDto.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
@filiphr
Update processor/src/test/java/org/mapstruct/ap/test/nestedbeans/Hous…
9b41606 
…eDto.java
@filiphr filiphr added the refactoring label Aug 1, 2023
@filiphr filiphr added this to the 1.6.0 milestone Aug 1, 2023
@filiphr
filiphr merged commit b2dc641 into mapstruct:main Aug 1, 2023
@filiphr

filiphr commented Aug 1, 2023

Copy link
Copy Markdown
Member

thank @anton-erofeev
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@filiphr filiphr filiphr requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

refactoring

Projects

None yet

Milestone

1.6.0.Beta1

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@anton-erofeev @filiphr
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.