GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — #3347 Use presence checks for checking source parameter presence by filiphr · Pull Request #3348 · mapstruct/mapstruct

Conversation

@filiphr

@filiphr filiphr commented Aug 1, 2023

Copy link
Copy Markdown
Member

Instead of explicitly doing a null check use a PresenceCheck mechanism for

  • BeanMappingMethod
  • ContainerMappingMethod
  • MapMappingMethod

Fixes #3347

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@filiphr
Use presence checks for checking source parameter presence
97b3a71 
Instead of explicitly doing a null check use a PresenceCheck mechanism for
* BeanMappingMethod
* ContainerMappingMethod
* MapMappingMethod
@filiphr
filiphr merged commit 812faee into mapstruct:main Aug 1, 2023
@filiphr
filiphr deleted the source-presence-check-refactoring branch August 1, 2023 13:41
@filiphr filiphr mentioned this pull request Aug 1, 2023
#674 Support for native Java 8 Optional mapping #3183
Closed
7 of 8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor to use presence check for mapping methods

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@filiphr
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.