GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — #3667, #3673 MappingReference should custom MappingOption equality instead of the default only target name based one by filiphr · Pull Request #3677 · mapstruct/mapstruct

Conversation

@filiphr

@filiphr filiphr commented Aug 18, 2024

Copy link
Copy Markdown
Member

Fixes #3667
Fixes #3673

The main culprit for this was due to the fact that the MappingReference was using MappingOption equality and the MappingOption is based only on the targetName, but we need to take sourceName, constant and expression into consideration.

All the tests should be green, and I hope that this isn't causing another regression.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@filiphr
mapstruct#3667, mapstruct#3673 MappingReference should custom Mapping…
f179d73 
…Option equality instead of the default only target name based one
thunderhook
thunderhook approved these changes Aug 21, 2024
View reviewed changes

@thunderhook thunderhook left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@filiphr
filiphr merged commit 6c8a2e1 into mapstruct:main Aug 24, 2024
@filiphr
filiphr deleted the 3667_3673 branch August 24, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thunderhook thunderhook thunderhook approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Two different constants are ignored Deep mapping with multiple mappings broken in 1.6.0

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@filiphr @thunderhook
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.