GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: methods contained in @Context classes don't support generics by tangyang9464 · Pull Request #3867 · mapstruct/mapstruct

Conversation

@tangyang9464

@tangyang9464 tangyang9464 commented May 23, 2025

Copy link
Copy Markdown
Contributor

fix: #3711

The bug is caused by not handling generics properly when generating context methods

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
filiphr
filiphr requested changes May 25, 2025
View reviewed changes

@filiphr filiphr left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @tangyang9464. I've left a comment, I am not too fond of the fix. I would rather do it slightly differently.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread processor/src/main/java/org/mapstruct/ap/internal/processor/MethodRetrievalProcessor.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
@tangyang9464
tangyang9464 force-pushed the fix/3711 branch 2 times, most recently from 51e397d to f90fa37 Compare May 26, 2025 03:12
@tangyang9464
fix: methods contained in @context classes don't support generics
b680779 
Signed-off-by: TangYang <[email protected]>
@tangyang9464
tangyang9464 force-pushed the fix/3711 branch from f90fa37 to b680779 Compare May 26, 2025 03:18
@tangyang9464

tangyang9464 commented May 26, 2025

Copy link
Copy Markdown
Contributor Author

Why don't we change the first method of the retrieveMethods and instead of passing TypeElement for the usedMapper we can pass our Type.

@filiphr done. plz review again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@filiphr
Polish
c0c0b32
filiphr
filiphr approved these changes May 31, 2025
View reviewed changes
@filiphr
filiphr merged commit 5464c3c into mapstruct:main May 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@filiphr filiphr filiphr approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support generic @Context

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@tangyang9464 @filiphr
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.