GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — upgrade integration tests to junit5 by hduelme · Pull Request #4023 · mapstruct/mapstruct

Conversation

@hduelme

@hduelme hduelme commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

The compile tests were still using JUnit4. This PR fully migrates the integration tests to JUnit5.
To achieve this:

  • Upgraded Arquillian to version 1.7.2.Final (newer versions currently cause issues with @WithCdi)
  • Updated Spring tests to use JUnit6 by overriding the org.junit.jupiter.version property. (springframework version 7 requires JUnit6)
  • Applied JUnit5 conventions and code style across the test suite

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hduelme
upgrade integration tests to junit5
031738f
@filiphr

filiphr commented Mar 26, 2026

Copy link
Copy Markdown
Member

Thanks @hduelme. Mostly it looks OK. I'm curious, why couldn't we upgrade to JUnit 6 everywhere? What isn't working if we do that?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hduelme

hduelme commented Mar 27, 2026

Copy link
Copy Markdown
Contributor Author

@filiphr I attempted to upgrade to JUnit 6, but encountered a compatibility issue.
JUnit 6 requires Java 17 as a minimum, which breaks our CI pipeline for Java 8 and Java 11 environments. The build failure is visible in the linked CI run:https://github.com/hduelme/mapstruct/actions/runs/23637604503/job/68850229523.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@filiphr

filiphr commented Mar 27, 2026

Copy link
Copy Markdown
Member

Gotcha, thanks @hduelme. I guess we are soon going to need to bump to Java 17 as baseline. But let's do that after MapStruct 1.7.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@filiphr
filiphr merged commit 6a56751 into mapstruct:main Mar 27, 2026
5 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@filiphr filiphr added the build label Mar 27, 2026
@filiphr filiphr added this to the 1.7.0.Beta2 milestone Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

build

Projects

None yet

Milestone

1.7.0.Beta2

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@hduelme @filiphr
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.