GeezerVison

@filiphr @JanecekPetr Please Review! Thank you.

@Takch02 nice implementation.
I see why you assumed that getFromExpression should not be implemented. However, in other conversions we already use ZoneOffset.UTC as a default value, for example in JavaLocalDateToDateConversion and JavaLocalDateToSqlDateConversion.
Could you add the getFromExpression implementation and the according tests?

@Takch02 nice implementation. I see why you assumed that getFromExpression should not be implemented. However, in other conversions we already use ZoneOffset.UTC as a default value, for example in JavaLocalDateToDateConversion and JavaLocalDateToSqlDateConversion. Could you add the getFromExpression implementation and the according tests?

@hduelme Thanks for the review! I added getFromExpression and related tests.

@Takch02 the implementation looks clean to me.
Could you add the missing license header to SourceTargetMapperImpl? We ignore license headers in diffs, but we still want every file to include one.

Additionally, @JanecekPetr noticed that mapping to/from Instant is still missing:

Similarly, I now see that neither ZonedDateTime nor OffsetDateTime cannot be converted to Instant at all, even though zonedDateTime.toInstant() exists.

If you'd like, you could implement those mappings as well.

@Takch02 the implementation looks clean to me. Could you add the missing license header to SourceTargetMapperImpl? We ignore license headers in diffs, but we still want every file to include one.

Additionally, @JanecekPetr noticed that mapping to/from Instant is still missing:

Similarly, I now see that neither ZonedDateTime nor OffsetDateTime cannot be converted to Instant at all, even though zonedDateTime.toInstant() exists.

If you'd like, you could implement those mappings as well.

@hduelme Thank you! l added license headers and conversion Instant/LocalDataTime, Instant/ZoneDateTime

@Takch02 thanks a lot.
I forgot to mention earlier that built-in conversions are documented in chapter-5-data-type-conversions.asciidoc. Could you also add documentation for the 4 newly added conversions?

@Takch02 thanks a lot. I forgot to mention earlier that built-in conversions are documented in chapter-5-data-type-conversions.asciidoc. Could you also add documentation for the 4 newly added conversions?

@hduelme Thank you! I added documentation for the 4 new conversion.

@Takch02 thanks again. Its now merged.

@hduelme Thank you!!