GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — remove reflection from isDefaultMethod by hduelme · Pull Request #4053 · mapstruct/mapstruct

Conversation

@hduelme

@hduelme hduelme commented May 11, 2026

Copy link
Copy Markdown
Contributor

Since Java 8, ExecutableElement.isDefault() is always available. As MapStruct now requires Java 8 as the minimum supported version, the reflective check is no longer necessary.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hduelme
remove reflection from isDefaultMethod
ef6de52
@filiphr
filiphr merged commit c627f78 into mapstruct:main May 11, 2026
9 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@filiphr filiphr added the refactoring label May 11, 2026
@filiphr

filiphr commented May 11, 2026

Copy link
Copy Markdown
Member

Nice one @hduelme
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@filiphr filiphr added this to the 1.7.0.Beta2 milestone May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

refactoring

Projects

None yet

Milestone

1.7.0.Beta2

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@hduelme @filiphr
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.