GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — MLE-33564 Fix the 5 fixable disabled tests by hmadala001 · Pull Request #1985 · marklogic/java-client-api

Conversation

hmadala001 commented Nov 4, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

BulkReadWriteTest (testA_BulkLoad, testB_BulkRead, testC_BulkSearch):

Load cities_above_300K.txt in @BeforeAll so the tests no longer depend on running in method-name order; testA_BulkLoad now verifies the loaded count.
Removed @disabled.

TestBiTemporal (testPeriodRangeQuerySingleAxisBasedOnALNContains, testPeriodRangeQueryMultiplesAxesBasedOnALNContains):

Query periods are now derived by offsets from the valid times the test writes, and are built in UTC rather than the JVM default timezone, which made the tests fail whenever the JVM was not running in UTC.
Removed @disabled.

https://ml-clt-jenkins.progress.com/blue/organizations/jenkins/devexp%2FJava-Client%2Fjava-client-api/detail/PR-1985/3/tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

hmadala001 requested review from NiteshMehta, adganta, ashokrprogress, prgs-rsingh, rjrudin and vishwach as code owners

November 4, 2026 08:04

Copilot AI balanced review requested due to automatic review settings

November 4, 2026 08:04

Copilot started reviewing on behalf of hmadala001

November 4, 2026 08:04

View session

Copilot AI reviewed

Nov 4, 2026

View reviewed changes

Copilot AI left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

There are no active review issues for the changes re-enabling bulk and temporal test coverage.

No open issues 🎉

What changed in this PR

Re-enables five disabled tests in the core client and functional test suites by removing bulk-test ordering dependencies and making temporal query periods independent of the JVM’s default timezone.

Changes:

Loads city data once in @BeforeAll and changes the bulk-load test to verify the loaded count.
Derives temporal query boundaries from shared valid-time constants using UTC and one-second offsets.
Removes @Disabled from three bulk tests and two temporal tests.

File	Description
`marklogic-client-api/src/test/java/com/marklogic/client/test/BulkReadWriteTest.java`	Initializes shared city data before all tests and re-enables bulk load, read, and search coverage.
`marklogic-client-api-functionaltests/src/test/java/com/marklogic/client/functionaltest/TestBiTemporal.java`	Adds UTC query-period construction and re-enables two `ALN_CONTAINS` tests.

_{Review effort: Balanced}

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          MLE-33564 Fix the 5 fixable disabled tests

32361f1

BulkReadWriteTest (testA_BulkLoad, testB_BulkRead, testC_BulkSearch):
- Load cities_above_300K.txt in @BeforeAll so the tests no longer depend on
  running in method-name order; testA_BulkLoad now verifies the loaded count.
- Removed @disabled.

TestBiTemporal (testPeriodRangeQuerySingleAxisBasedOnALNContains,
testPeriodRangeQueryMultiplesAxesBasedOnALNContains):
- Query periods are now derived by offsets from the valid times the test
  writes, and are built in UTC rather than the JVM default timezone, which made
  the tests fail whenever the JVM was not running in UTC.
- Removed @disabled.

MLE-33564 Update copyright year to 2026 in BulkReadWriteTest

The Validate Copyright Headers check requires modified files to carry the
current year.

Revert "MLE-33564 Temporarily pin PR build to MarkLogic 12.2.20261005"

This reverts commit 493a518.

Co-Authored-By: Copilot <[email protected]>

hmadala001 force-pushed the MLE-33564 branch from 2149752 to 32361f1 Compare

November 10, 2026 09:55

prgs-rsingh approved these changes

Nov 10, 2026

View reviewed changes

prgs-rsingh left a comment

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great root-cause fix on both fronts:

BulkReadWriteTest (testA_BulkLoad, testB_BulkRead, testC_BulkSearch): Moving cleanUp() and loadCities(new BulkCityWriter()) into @BeforeAll removes the method-ordering dependency while keeping loadCities available for JacksonDatabindTest and PojoFacadeTest.
TestBiTemporal (testPeriodRangeQuerySingleAxisBasedOnALNContains, testPeriodRangeQueryMultiplesAxesBasedOnALNContains): Constructing the Calendar bounds in UTC via utcValidTime(validTime, offsetSeconds) resolves the timezone mismatch between a non-UTC client JVM and the UTC MarkLogic Docker container when StructuredQueryBuilder.period(Calendar, Calendar) serializes the Calendar with its timezone offset.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

ashokrprogress approved these changes

Nov 10, 2026

View reviewed changes

Reviewers

Copilot code review Copilot

Copilot review effort

Applies to this pull request for everyone.Learn more about Copilot code review.

Copilot left review comments

prgs-rsingh

prgs-rsingh approved these changes

ashokrprogress

ashokrprogress approved these changes

rjrudin

Awaiting requested review from rjrudin

rjrudin is a code owner

NiteshMehta

Awaiting requested review from NiteshMehta

NiteshMehta is a code owner

vishwach

Awaiting requested review from vishwach

vishwach is a code owner

adganta

Awaiting requested review from adganta

adganta is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

hmadala001 commented Nov 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

prgs-rsingh left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hmadala001 commented Nov 4, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.