GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — fix(notes): preserve selected note for ambiguous internal links by antonreshetov · Pull Request #957 · massCodeIO/massCode Conversation
Member
Selecting a note in the internal-link picker could open a same-named code snippet because the inserted title-only link resolves to snippets first. Use a typed note ID with a readable label when a note name collides with another entity type, including case-insensitive matches. Keep ordinary title and folder-path links for other selections. Validation: 106 scoped tests passed; staged-file formatting and ESLint passed. UI QA confirmed distinct note/snippet targets and persistence after reopening and renderer reload. Native Cmd-click navigation was not exercised because the UI automation tool lacks modifier-click support; navigation handlers are covered by tests. Closes #947
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersNo reviewsUh oh!
There was an error while loading. Please reload this page. AssigneesLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. [Bug]: internal link referencing code and not noteUh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |