GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(storage): write vault files atomically to avoid truncation on failure by antonreshetov · Pull Request #985 · massCodeIO/massCode

Conversation

@antonreshetov

@antonreshetov antonreshetov commented Oct 14, 2026

Copy link
Copy Markdown
Member

Notes, snippets, HTTP requests, folder .meta.yaml, state.json / .state.yaml and doctor id fixes were written with fs.writeFileSync over the existing file. It truncates first, so ENOSPC/EIO in the middle of a write left a cut-off file on disk even though the runtime rolled back.

  • Add writeFileAtomicSync in runtime/shared/atomicWrite.ts: write a hidden .<name>.<hex>.tmp next to the target, then renameSync over it. Preserves the file mode, writes through symlinks, removes the temp file on failure, falls back to an in-place write on Windows when the target is locked by another process.
  • Use it in all vault writers listed above.
  • Tests: unit tests for the helper, partial-write and failed-rename cases for notes and snippets; path-keyed write mocks moved to renameSync.

Checked on a real iCloud Drive vault with the dev build: repeated saves, rename/move, external edits picked up by the watcher, upload without conflicts, content verified after eviction, edits blocked until a dataless note is downloaded.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@antonreshetov
fix(storage): write vault files atomically to avoid truncation on fai…
1a0cb45
…lure
@antonreshetov antonreshetov self-assigned this Oct 14, 2026
@antonreshetov
antonreshetov merged commit 1b68763 into main Oct 14, 2026
@antonreshetov
antonreshetov deleted the fix/atomic-vault-writes branch October 14, 2026 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@antonreshetov antonreshetov

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@antonreshetov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.