GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fixes by at-cf by clickingbuttons · Pull Request #297 · massive-com/client-python

Conversation

@clickingbuttons

@clickingbuttons clickingbuttons commented Sep 6, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Closes #293
Closes #294

Bonus example to measure latency/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@clickingbuttons
Fixes by at-cf
28808e2
@clickingbuttons
clickingbuttons requested a review from Darcy-Linde as a code owner September 6, 2022 14:21
@clickingbuttons
fix lint
e8e2eb9
morningvera
morningvera approved these changes Sep 9, 2022
View reviewed changes

@morningvera morningvera left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@clickingbuttons
clickingbuttons merged commit 7133688 into master Sep 9, 2022
@clickingbuttons
clickingbuttons deleted the contrib-fixes branch September 9, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Darcy-Linde Darcy-Linde Awaiting requested review from Darcy-Linde
1 more reviewer
@morningvera morningvera morningvera approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

WebSocketClient raw handling should be improved Subscriptions are not changed until a message from existing subscription is received

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@clickingbuttons @morningvera
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.