GeezerVison is showing github.com — include date param in get_ticker_details by jakekdodd · Pull Request #321 · massive-com/client-python
Conversation
jakekdodd
commented
Oct 30, 2022
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Fixes #320
I put a second assert in the same test method, but happy to factor the expected response data out and create a second test method, if you prefer to follow the "one assertion per test" paradigm
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
clickingbuttons
left a comment
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We did nothing wrong... /s
Thanks for the catch! I'll cut a release shortly.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
jakekdodd reacted with laugh emoji
jakekdodd reacted with hooray emoji
All reactions
-
😄
1 reaction
-
🎉
1 reaction
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
1 more reviewer
Reviewers whose approvals may not affect merge requirements
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
