GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — new feature: named figures by butterw · Pull Request #100 · matplotlib/matplotlib

Conversation

@butterw

@butterw butterw commented Apr 28, 2011

Copy link
Copy Markdown

I will add some test to support the proposed new feature.

I've not implemented plt.close("today"), because I'm unsure whether it is absolutely required.

PS: It doesn't seem possible to attach a pull request to an existing issue ?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@butterw

butterw commented Apr 28, 2011

Copy link
Copy Markdown
Author

I've closed the previously opened issue (that didn't contain any code):

this small addition will make it possible to use explicitly named figures in pyplot.figure

Example:

plt.figure("today")
opens new or existing figure with label "today".
In windowed backends, the title of the figure window will be set to "today" instead of Figure 1.
Internally all figures remain tracked using fig.number.

The expected benefit of this patch is to make it easier to switch between multiple figures.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@butterw

butterw commented Jun 15, 2011

Copy link
Copy Markdown
Author

I've now added tests >> The code is ready for review.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mdboom

mdboom commented Jun 15, 2011

Copy link
Copy Markdown
Member

Nice. I think plt.close('today') should be added, though, for completeness.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@butterw

butterw commented Jun 15, 2011

Copy link
Copy Markdown
Author

the commits seem to have messed up a bit !

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ddale

ddale commented Jun 16, 2011

Copy link
Copy Markdown
Contributor

This can't be merged in its current state. Please redo commit a2e82eb without adding the example files.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@butterw
butterw merged commit c5c9f69 into matplotlib:master Jun 17, 2011
@richbwood richbwood mentioned this pull request Dec 19, 2012
test_pcolormesh hangs #1609
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.1.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@butterw @mdboom @ddale
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.