GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Use png files for all icon files in backend_qt4.py instead of svg by ruidc · Pull Request #143 · matplotlib/matplotlib

Conversation

@ruidc

@ruidc ruidc commented Jun 14, 2011

Copy link
Copy Markdown

Use png files for all icon files in backend_qt4.py instead of svg to circumvent dependency in Qt:
http://sourceforge.net/mailarchive/forum.php?thread_name=4D4EA423.5090802%40vanderHoeven.biz&forum_name=matplotlib-users

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
rui
Use png files for all icon files in backend_qt4.py instead of svg to …
d3d4b44 
…circumvent dependency in Qt:

http://sourceforge.net/mailarchive/forum.php?thread_name=4D4EA423.5090802%40vanderHoeven.biz&forum_name=matplotlib-users
@gstorer

gstorer commented Jun 15, 2011

Copy link
Copy Markdown
Contributor

The problem described in that thread is by and large just a problem with py2exe not knowing what to do with the Qt imageformat plugin DLLs. See this for a more detail explanation: http://stackoverflow.com/questions/4573995/pyqt-pyside-icon-display-problem/5643540#5643540

I'm not quite sure the reasoning behind using SVG, if there isn't a good reason then Qt backend should use the .png images as Qt natively supports PNG. If there's a reason for SVG then the problem described is just a quirk of the py2exe and Qt combination that is easy enough to work around when you know what's causing it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ruidc

ruidc commented Jun 15, 2011

Copy link
Copy Markdown
Author

"I'm not quite sure the reasoning behind using SVG, if there isn't a good reason then Qt backend should use the .png images as Qt natively supports PNG." - This is my point, as one of the icons was already using PNG, and this way, if there's no good reason for using SVG, we avoid an extra (non-obvious) dependency.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ddale ddale closed this in c61df40 Jun 15, 2011
@ddale

ddale commented Jun 15, 2011

Copy link
Copy Markdown
Contributor

I applied the changes to the v1.0.x-maint branch, and merged that into master. I suggest you not file pull requests from your master branch, as it has now diverged from upstream/master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@richbwood richbwood mentioned this pull request Dec 19, 2012
test_pcolormesh hangs #1609
Closed
@astrofrog astrofrog mentioned this pull request Sep 14, 2015
Use HiDPI icons for PyQt5 #5057
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ruidc @gstorer @ddale
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.