GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Warn on invalid savefig keyword arguments by QuLogic · Pull Request #17223 · matplotlib/matplotlib

Conversation

@QuLogic

@QuLogic QuLogic commented Apr 23, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Summary

This depends on #17221 and #17233 so that there are no warnings about metadata from saving SVG or PDF with the PGF backend.

Fixes #192.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@QuLogic QuLogic added API: consistency Consistency of the matplotlib API, including naming, behavior, defaults, … status: waiting for other PR labels Apr 23, 2020
@QuLogic
QuLogic force-pushed the savefig-extra-kwargs branch from 0bd3491 to cb47539 Compare April 23, 2020 06:02
@QuLogic
QuLogic force-pushed the savefig-extra-kwargs branch from cb47539 to f74575c Compare June 10, 2020 19:09
@QuLogic QuLogic removed the status: waiting for other PR label Jun 10, 2020
@QuLogic
QuLogic marked this pull request as ready for review June 10, 2020 19:13
@QuLogic

QuLogic commented Jun 10, 2020

Copy link
Copy Markdown
Member Author

Now ready, as the metadata PRs went in.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tacaswell tacaswell added this to the v3.3.0 milestone Jun 10, 2020
tacaswell
tacaswell approved these changes Jun 10, 2020
View reviewed changes
anntzer
anntzer reviewed Jun 11, 2020
View reviewed changes
Comment thread lib/matplotlib/backends/backend_agg.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
anntzer
anntzer reviewed Jun 11, 2020
View reviewed changes
Comment thread lib/matplotlib/backend_bases.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
QuLogic added 2 commits June 11, 2020 18:18
@QuLogic
Pop extra kwargs in FigureCanvasAgg.print_jpg.
63d239e
@QuLogic
Make quality kwarg explicit in FigureCanvasWx._print_image.
628d95a
@QuLogic
QuLogic force-pushed the savefig-extra-kwargs branch from f74575c to f25f1eb Compare June 12, 2020 01:02
@QuLogic

QuLogic commented Jun 12, 2020

Copy link
Copy Markdown
Member Author

I changed it into a decorator, as @anntzer requested. I wonder if also args should be removed from the final methods?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@QuLogic
Warn on invalid savefig keyword arguments.
b7a574f 
Fixes matplotlib#192.
@QuLogic
QuLogic force-pushed the savefig-extra-kwargs branch from f25f1eb to b7a574f Compare June 12, 2020 01:24
@anntzer

anntzer commented Jun 15, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Also removing args seems good to me?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@QuLogic
Also remove *args from print methods.
853d8c9
anntzer
anntzer approved these changes Jun 15, 2020
View reviewed changes
@anntzer

anntzer commented Jun 15, 2020

Copy link
Copy Markdown
Contributor

postci
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@QuLogic
QuLogic merged commit 7b76234 into matplotlib:master Jun 15, 2020
@QuLogic
QuLogic deleted the savefig-extra-kwargs branch June 15, 2020 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tacaswell tacaswell tacaswell approved these changes
@anntzer anntzer anntzer approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

API: consistency Consistency of the matplotlib API, including naming, behavior, defaults, …

Projects

None yet

Milestone

v3.3.0

Development

Successfully merging this pull request may close these issues.

Savefig does not issue a warning on a non-existent keyword n

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@QuLogic @anntzer @tacaswell
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.