GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Support full-sharex/y in subplot_mosaic. by anntzer · Pull Request #20107 · matplotlib/matplotlib

Conversation

@anntzer

@anntzer anntzer commented Apr 29, 2021

Copy link
Copy Markdown
Contributor

PR Summary

Implements the True/False case of #18305 (the "row"/"col" case is still missing).

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@anntzer
anntzer force-pushed the mosaicshares branch from 1e5b9fd to 92512f2 Compare April 29, 2021 09:45
story645
story645 approved these changes Apr 29, 2021
View reviewed changes
QuLogic
QuLogic reviewed Apr 29, 2021
View reviewed changes
Comment thread lib/matplotlib/figure.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread lib/matplotlib/figure.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@anntzer
anntzer force-pushed the mosaicshares branch from 92512f2 to 15a097d Compare April 30, 2021 07:16
@anntzer

anntzer commented Apr 30, 2021

Copy link
Copy Markdown
Contributor Author

thanks, fixed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tacaswell tacaswell added this to the v3.5.0 milestone Apr 30, 2021
QuLogic
QuLogic reviewed May 1, 2021
View reviewed changes
Comment thread lib/matplotlib/figure.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@anntzer
Support full-sharex/y in subplot_mosaic.
1fd0914
@anntzer
anntzer force-pushed the mosaicshares branch from 15a097d to 1fd0914 Compare May 1, 2021 10:27
QuLogic
QuLogic approved these changes May 3, 2021
View reviewed changes
@QuLogic
QuLogic merged commit 9177280 into matplotlib:master May 3, 2021
@anntzer
anntzer deleted the mosaicshares branch May 3, 2021 20:57
@tacaswell tacaswell mentioned this pull request Jun 30, 2021
Support simple axes shares in subplot_mosaic #18305
Open
@aimldlds aimldlds mentioned this pull request Aug 22, 2026
ENH: accept 'all'/'row'/'col' axis sharing in subplot_mosaic #32239
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuLogic QuLogic QuLogic approved these changes
@story645 story645 story645 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.5.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@anntzer @QuLogic @story645 @tacaswell
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.