GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Try to install the Noto Sans CJK font by jkseppan · Pull Request #20851 · matplotlib/matplotlib

Conversation

@jkseppan

@jkseppan jkseppan commented Aug 17, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

On Linux and Mac. Add a font_manager test that loads the font and uses it. This could be useful in testing the multi-font support (#20740 etc).

I couldn't get the font installed on Windows. There is a Chocolatey installer that installs all of the Noto fonts, which takes a really long time to run.

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jkseppan
jkseppan force-pushed the wqy-zenhei-install branch 7 times, most recently from 66965e0 to fd2d801 Compare August 18, 2021 15:56
@QuLogic

QuLogic commented Aug 18, 2021

Copy link
Copy Markdown
Member

Zen Hei seems packaged for Ubuntu, but in Universe, Not sure if we need to do something special to allow installing it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jkseppan
jkseppan force-pushed the wqy-zenhei-install branch from fd2d801 to cb0af05 Compare August 19, 2021 18:15
@jkseppan jkseppan changed the title Try to install WenQuanYi Zen Hei font Try to install Google Noto Sans fonts Aug 19, 2021
@jkseppan

jkseppan commented Aug 19, 2021

Copy link
Copy Markdown
Member Author

The SourceForge download of Zen Hei sometimes fails, so this was probably not a good idea. Google's Noto fonts seem to be better packaged in various systems, so perhaps something like Noto Sans CJK SC could be more useful.

For context: some of the new font changes by @aitikgupta crash on my computer (an M1 Mac) but not on his (I believe Linux on x86), so I would like to add a more cross-platform test with a CJK font and see if we can replicate the crash in CI.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jkseppan
jkseppan force-pushed the wqy-zenhei-install branch 2 times, most recently from c04d923 to a71185c Compare August 20, 2021 08:31
@jkseppan
Try to install the Noto Sans CJK font
bf38aa9 
On Linux and Mac. Add a font_manager test that loads the font and
uses it. This could be useful in testing the multi-font support
(matplotlib#20740 etc).

I couldn't get the font installed on Windows. There is a Chocolatey
installer that installs all of the Noto fonts, which takes a really
long time to run.
@jkseppan
jkseppan force-pushed the wqy-zenhei-install branch from 10558de to bf38aa9 Compare August 20, 2021 09:19
@jkseppan

jkseppan commented Aug 20, 2021

Copy link
Copy Markdown
Member Author

I'm giving up on Windows - the Chocolatey package installs all of the Noto fonts and takes half an hour to do it, and my PowerShell skills are not enough to install just one.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jkseppan jkseppan changed the title Try to install Google Noto Sans fonts Try to install the Noto Sans CJK font Aug 20, 2021
@jkseppan
jkseppan marked this pull request as ready for review August 20, 2021 10:17
@jkseppan jkseppan added topic: testing topic: text/fonts labels Aug 20, 2021
@jkseppan
jkseppan requested a review from aitikgupta August 21, 2021 11:49
aitikgupta
aitikgupta approved these changes Aug 21, 2021
View reviewed changes

@aitikgupta aitikgupta left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be a good validation for testing the font fallback.

If we do keep this, do we also need to keep installing ZenHei for CI (on Linux) as well?
Noto CJK could potentially replace it right? (I'll do a local installation to test out the actual difference between number of glyphs)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
anntzer
anntzer approved these changes Aug 30, 2021
View reviewed changes
@anntzer
anntzer merged commit 47077d1 into matplotlib:master Aug 30, 2021
@QuLogic QuLogic added this to the v3.6.0 milestone Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anntzer anntzer anntzer approved these changes
@aitikgupta aitikgupta aitikgupta approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic: testing topic: text/fonts

Projects

None yet

Milestone

v3.6.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@jkseppan @QuLogic @anntzer @aitikgupta
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.