GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix spacing after mathtext operators with sub/superscripts by timhoffm · Pull Request #23243 · matplotlib/matplotlib

Conversation

@timhoffm

@timhoffm timhoffm commented Jun 10, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Picks up #22839, which did not get author response. - This is #22839 plus adding the two minor comments from there. I don't want to force-push to a foreign branch, so I've opened a separate PR. Happy to close this in case #22839 gets response.

Closes #22839, #17852.

Co-authored-by: henrybeUM [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@oscargus oscargus added the topic: text/mathtext label Jun 11, 2022
anntzer
anntzer approved these changes Jun 11, 2022
View reviewed changes
oscargus
oscargus reviewed Jun 11, 2022
View reviewed changes
Comment thread lib/matplotlib/tests/test_mathtext.py Outdated
fig_test.text(0.1, 0.8, r"$\log_2$")
# Check spacing after Sub/Super scripts
# Github issue 17852
fig_test.text(0.1, 0.7, r"$\sin^2 \cos$")

@oscargus oscargus Jun 11, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should one position the text elsewhere? Although it may not be the case here, if one continue to reuse coordinates sooner or later there will be a black area...

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@timhoffm timhoffm Jun 12, 2022

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, of course.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@timhoffm @henrybeUM
Fix spacing after mathtext operators with sub/superscripts
ed4a462 
Picks up matplotlib#22839.

Closes matplotlib#22839, matplotlib#17852.

Co-authored-by: henrybeUM <[email protected]>
@timhoffm
timhoffm force-pushed the take-over-22839 branch from 0380a24 to ed4a462 Compare June 12, 2022 21:17
oscargus
oscargus approved these changes Jun 12, 2022
View reviewed changes
@oscargus
oscargus merged commit 60ae76b into matplotlib:main Jun 12, 2022
@oscargus oscargus mentioned this pull request Jun 13, 2022
Thin space missing after mathtext operators #17852
Closed
@timhoffm
timhoffm deleted the take-over-22839 branch June 13, 2022 04:59
@QuLogic QuLogic added this to the v3.6.0 milestone Jun 14, 2022
@anntzer anntzer mentioned this pull request Nov 1, 2025
Fix spacing in r"$\max f$". #30715
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anntzer anntzer anntzer approved these changes
@oscargus oscargus oscargus approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic: text/mathtext

Projects

None yet

Milestone

v3.6.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@timhoffm @anntzer @oscargus @QuLogic
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.