GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Mathtext spaces must be independent of font style. by tfpf · Pull Request #23482 · matplotlib/matplotlib

Conversation

@tfpf

@tfpf tfpf commented Jul 23, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR Summary

Fixes #23474.
before

The width of the space inserted by, for instance, \, and \mathrm{\,}, is now the same.
after

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [N/A] New features are documented, with examples if plot related.
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tfpf
tfpf marked this pull request as ready for review July 23, 2022 06:04
@anntzer anntzer added the topic: text/mathtext label Jul 24, 2022
anntzer
anntzer approved these changes Jul 24, 2022
View reviewed changes

@anntzer anntzer left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See rationale at #23474 (comment): maybe not the absolutely correct solution, but certainly the most practical one.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
anntzer
anntzer reviewed Jul 24, 2022
View reviewed changes
Comment thread lib/matplotlib/_mathtext.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@tfpf
Mathtext spaces must be independent of font style.
686dffa
@tfpf
tfpf force-pushed the consistent-spacing branch from 2322e05 to 686dffa Compare July 25, 2022 09:16
QuLogic
QuLogic approved these changes Jul 26, 2022
View reviewed changes
@QuLogic QuLogic added this to the v3.6.0 milestone Jul 26, 2022
@QuLogic
QuLogic merged commit 5fc0441 into matplotlib:main Jul 26, 2022
@tfpf
tfpf deleted the consistent-spacing branch July 26, 2022 04:38
@tfpf tfpf mentioned this pull request Jan 31, 2026
Implement TeX's fraction and script alignment #31046
Merged
2 of 5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anntzer anntzer anntzer approved these changes
@QuLogic QuLogic QuLogic approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic: text/mathtext

Projects

None yet

Milestone

v3.6.0

Development

Successfully merging this pull request may close these issues.

[Bug]: \, and \mathrm{\,} are not identical in Mathtext when using CM and STIX

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@tfpf @QuLogic @anntzer
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.