GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||||||
GeezerVison is showing github.com — Start using Cirrus CI by oscargus · Pull Request #24597 · matplotlib/matplotlib Conversation
Member
PR SummaryI expect quite a few attempts... PR ChecklistDocumentation and Tests
Release Notes
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
oscargus
marked this pull request as draft
oscargus
force-pushed
the
cirrusci
branch
25 times, most recently
from
5686fcf to
1ca320e
Compare
Member
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Member
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
QuLogic
reviewed
Uh oh!
There was an error while loading. Please reload this page.
QuLogic
reviewed
Uh oh!
There was an error while loading. Please reload this page.
|
There was an error while loading. Please reload this page.
|
This is now good on aarch64 due to changes here and the linked PRs. The M1 macOS build should also pass, but it's failing due to homebrew breakage. I don't know if we want to continue to use mactex; it seems to take the majority of the OS setup part of the build. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
OK, adding a |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
There was a recent post on the numpy-mailing list that they are now exceeding the free quota on Cirrus. Not sure if it will become a problem for us as well, but I can imagine it may be. Especially since our tests takes quite a bit of longer time. Anyway, as a small counter measure it has been suggested running their tests in sequence, starting with the linux one numpy/numpy#24435 We may consider having these optional as well, just running them with a certain label or similar. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Setting up the Mac environment seems to be the major culprit here. Not sure if we are charged all four CPUs during that time and/or it we can try to make use of all four CPUs somehow to reduce the install time? In general, adding a 39 minute test seems a bit unfortunate. But maybe we can reduce that using caching and/or our own image? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Scrolling back I note that you have already noted the potential issue... However, I also noted this log message: which seems to be set by the image? Maybe one will just have to wait for the image to be updated... |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
One of the biggest time sinks on macOS M1 is installing MacTeX; we may want to not do that to save some time. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Just noting this (should be solved at some stage I guess, but not required for merging IMHO): for both runs. I guess that means that there are still issues for some users to install from source as well? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Btw, do we know if previous tests will be cancelled when pushing a new version? Considering the limited resources, we should try to confirm this/make it happen... |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
This is because their checkout does a shallow clone without tags. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Yes, it seems so on any branch other than |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
May be worth modifying it so that it does cancel even on |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I tried to see if one somehow can trigger the runs based on setting a specific label, but to no avail. An option is to use manual https://cirrus-ci.org/guide/writing-tasks/#manual-tasks and then do a bit of a guessing game if the PR may affect anything... (Not sure exactly who can trigger it though.) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
This is fixed now by adding the
I'm not sure we should try to optimize too much before finding out if we're going to end up close to the limit. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Turns out if we wait long enough, GHA has M1 now... |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
It looks like those are xlarge runners, which are only available for GitHub Team or GitHub Enterprise Cloud plans. So we'd still need to wait some more. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Comparing the previous build on aarch64, it took >2min to build, and now takes 34s, a factor of about 4, which matches CPU count. So the Meson build does seem to be taking advantage of all CPUs as expected. On macOS, it was 43s and now 15s, which is only 3x, but that might be too fast already. Oddly, there are new image failures on aarch64. I'm not sure why that's happening as that test image doesn't seem to have changed. Perhaps it's about optimizations or similar. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
It appears we have waited long enough, at least for M1 macOS: #27723 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Co-authored-by: Elliott Sales de Andrade <[email protected]>
|
Is it worth closing this now we can get native M1 runners on GH actions? #27723 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Unless we think that aarch64-Linux is worthwhile, I'd be happy to close this. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
aarch64-linux runners are available on GH actions now now: https://github.blog/changelog/2025-01-16-linux-arm64-hosted-runners-now-available-for-free-in-public-repositories-public-preview/, so I think this has become redundant? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Yes, I think unfortunately or fortunately, this PR is no longer needed. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Cirrus CI is shutting down June 1, 2026, so this is even less necessary: https://cirruslabs.org/ |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.