GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — MNT: remove test images from mathtext tests that have been removed by tacaswell · Pull Request #26132 · matplotlib/matplotlib

Conversation

@tacaswell

@tacaswell tacaswell commented Jun 15, 2023

Copy link
Copy Markdown
Member

b0dbead via #19314 several tests were merged but the images for them were not removed.

Found this while auditing the test images as part of overhauling how we manage the baseline images.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tacaswell
MNT: remove test images from mathtext tests that have been removed
2f89bc0 
b0dbead via matplotlib#19314 several tests
were merged but the images for them were not removed.
@tacaswell tacaswell added this to the v3.8.0 milestone Jun 15, 2023
@ksunden

ksunden commented Jun 15, 2023

Copy link
Copy Markdown
Member

Test failures on mac look similar to the others we were seeing on azure, where Tk has incompatible versions that are getting cross-linked...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
QuLogic
QuLogic approved these changes Jun 15, 2023
View reviewed changes
@QuLogic QuLogic added topic: text/mathtext CI: testing CI configuration and testing labels Jun 15, 2023
@ksunden

ksunden commented Jun 15, 2023

Copy link
Copy Markdown
Member

Test failures unrelated, going to go ahead and merge
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ksunden
ksunden merged commit 67c4bb3 into matplotlib:main Jun 15, 2023
@tacaswell
tacaswell deleted the tst/remove_extra_images branch June 15, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuLogic QuLogic QuLogic approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

CI: testing CI configuration and testing topic: text/mathtext

Projects

None yet

Milestone

v3.8.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@tacaswell @ksunden @QuLogic
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.