GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Make mypy a bit stricter by QuLogic · Pull Request #27796 · matplotlib/matplotlib

Conversation

@QuLogic

@QuLogic QuLogic commented Feb 16, 2024

Copy link
Copy Markdown
Member

PR summary

This follows some suggestions from Scientific Python's Repo-Review (I don't agree with everything there, but at least the MyPy stuff seems fine), and also moves config from the CI to pyproject.toml for re-use/visibility.

PR checklist

  • [n/a] "closes #0000" is in the body of the PR description to link the related issue
  • new and changed code is tested
  • [n/a] Plotting related features are demonstrated in an example
  • [n/a] New Features and API Changes are noted with a directive and release note
  • [n/a] Documentation complies with general and docstring guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
QuLogic added 4 commits February 15, 2024 20:58
@QuLogic
mypy: Warn about unreachable code
34d80c3 
And also fix some types to fix those warnings.
@QuLogic
TYP: Add more types for things that are public
91a82ea
@QuLogic
TYP: Make mypy stricter on error code checking
f2cd6b2 
These options are based on Scientific Python development guide:
https://learn.scientific-python.org/development/guides/repo-review/?repo=matplotlib%2Fmatplotlib&branch=main
@QuLogic
TYP: Move mypy options into config file
bbd3723 
Instead of putting them in CI, so that one can run `mypy` by itself and
not have to remember the flags to match CI.
@QuLogic QuLogic added this to the v3.9.0 milestone Feb 16, 2024
@github-actions github-actions Bot added topic: path handling topic: pyplot API labels Feb 16, 2024
@QuLogic QuLogic added the topic: typing label Feb 16, 2024
ksunden
ksunden approved these changes Feb 16, 2024
View reviewed changes
timhoffm
timhoffm approved these changes Feb 16, 2024
View reviewed changes
@timhoffm
timhoffm merged commit 810a43b into matplotlib:main Feb 16, 2024
@QuLogic
QuLogic deleted the stricter-mypy branch February 16, 2024 08:27
@ksunden ksunden mentioned this pull request May 12, 2025
Type-1 font subsetting #20716
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ksunden ksunden ksunden approved these changes
@timhoffm timhoffm timhoffm approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic: path handling topic: pyplot API topic: typing

Projects

None yet

Milestone

v3.9.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@QuLogic @ksunden @timhoffm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.