GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Disable clipping in Agg resamplers. by anntzer · Pull Request #28122 · matplotlib/matplotlib

Conversation

@anntzer

@anntzer anntzer commented Apr 23, 2024

Copy link
Copy Markdown
Contributor

I chose to add macro guards directly in the agg source as that seemed easier than copy-pasting the whole code.

I chose to bump the tolerance on test_rgba_antialias (as that's also getting bumped by the interpolation_stage antialias PR) and to test_pngsuite (which is not particularly relevant), and to update the other baselines.

PR summary

PR checklist

  • "closes #0000" is in the body of the PR description to link the related issue
  • new and changed code is tested
  • Plotting related features are demonstrated in an example
  • New Features and API Changes are noted with a directive and release note
  • Documentation complies with general and docstring guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@anntzer anntzer added the topic: images label Apr 23, 2024
@anntzer anntzer added this to the v3.10.0 milestone Apr 23, 2024
@anntzer
anntzer force-pushed the aggunclip branch from b531271 to 4141c23 Compare April 23, 2024 11:07
@greglucas

greglucas commented Jun 29, 2024

Copy link
Copy Markdown
Contributor

Wow, this looks like a really nice simplification and should fix some of the high dynamic range issues where we ran into problems around the 0.1/0.9 floating point representation creating incorrect under/over values.

Is this waiting on #28061 ?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
greglucas
greglucas approved these changes Jun 29, 2024
View reviewed changes
@anntzer

anntzer commented Jul 8, 2024

Copy link
Copy Markdown
Contributor Author

Apologies for the slow reply, I have basically no time to work on this these days (just a temporary thing).
I think this is actually fairly independent of #28061 (the rebase seems to work directly except for the fact that both PRs bump the tolerance on the same test), so they can probably(?) be merged in either order, except perhaps(?) if one wants to optimize baseline image weight in the git history?
If #28061 gets merged first, feel free to push a rebase of this PR to get it in if I don't do it quickly.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
timhoffm
timhoffm approved these changes Jul 8, 2024
View reviewed changes
@timhoffm

timhoffm commented Jul 8, 2024

Copy link
Copy Markdown
Member

TBH, I've not followed the relation with #28061, so I'm not clear whether we can just merge or whether we should wait. The change itself is good to go.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jklymak
jklymak reviewed Jul 8, 2024
View reviewed changes

@jklymak jklymak left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is likely correct and certainly doesn't need to wait on #28061. But maybe @tacaswell should weigh in as the previous method was his.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@github-actions github-actions Bot added the status: needs rebase label Jul 12, 2024
@anntzer
Disable clipping in Agg resamplers.
c7eb84a 
I chose to add macro guards directly in the agg source as that seemed
easier than copy-pasting the whole code.

I chose to bump the tolerance on test_rgba_antialias (as that's
also getting bumped by the interpolation_stage antialias PR) and to
test_pngsuite (which is not particularly relevant), and to update the
other baselines.
@anntzer
anntzer force-pushed the aggunclip branch from 4141c23 to c7eb84a Compare July 16, 2024 14:48
@github-actions github-actions Bot removed the status: needs rebase label Jul 16, 2024
@greglucas
greglucas merged commit 24c3f1a into matplotlib:main Jul 22, 2024
@anntzer
anntzer deleted the aggunclip branch July 22, 2024 17:13
@tacaswell

tacaswell commented Jul 22, 2024

Copy link
Copy Markdown
Member

Thank you for getting this done!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tacaswell tacaswell mentioned this pull request Aug 15, 2024
[Bug]: Plotting numpy.array of dtype float32 with pyplot.imshow and specified colors.LogNorm produces wrong colors #28731
Closed
@anntzer anntzer mentioned this pull request Sep 19, 2024
[Bug]: Incorrect color mapping close to normalization limits for float32 inputs #21167
Open
@anntzer anntzer mentioned this pull request Jun 18, 2025
Fixed several accuracy bugs with image resampling #30184
Merged
1 task done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jklymak jklymak jklymak left review comments
@timhoffm timhoffm timhoffm approved these changes
@greglucas greglucas greglucas approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic: images

Projects

None yet

Milestone

v3.10.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@anntzer @greglucas @timhoffm @tacaswell @jklymak
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.