GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Backport PR #29827 on branch v3.10.x (TST: Remove unnecessary test images) by QuLogic · Pull Request #29867 · matplotlib/matplotlib

Conversation

@QuLogic

@QuLogic QuLogic commented Apr 5, 2025

Copy link
Copy Markdown
Member

PR summary

Note that I only backported the first commit of #29827; I don't think it makes sense to make the API change of check_figures_equal defaults in a bug fix release.

PR checklist

  • [n/a] "closes #0000" is in the body of the PR description to link the related issue
  • new and changed code is tested
  • [n/a] Plotting related features are demonstrated in an example
  • [n/a] New Features and API Changes are noted with a directive and release note
  • [n/a] Documentation complies with general and docstring guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@QuLogic QuLogic added the topic: testing label Apr 5, 2025
@QuLogic QuLogic added this to the v3.10.2 milestone Apr 5, 2025
@dstansby

dstansby commented Apr 18, 2025

Copy link
Copy Markdown
Member

A rebase should fix the doc build, if this is something we still want to backport.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@QuLogic @dstansby
Backport PR matplotlib#29827: TST: Remove unnecessary test images
59a9774
@dstansby
dstansby force-pushed the auto-backport-of-pr-29827-on-v3.10.x branch from 2f88659 to 59a9774 Compare April 24, 2025 21:43
@dstansby

dstansby commented Apr 24, 2025

Copy link
Copy Markdown
Member

I've rebased on to the latest v3.10.x
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ksunden

ksunden commented May 2, 2025

Copy link
Copy Markdown
Member

Rerunning failed Azure Linux checks. They were all timeout errors, not image test errors, so probably unrelated to the changes here, but there were 9 failures, which is more than we usually see for stochastic failures. And it was on Linux where the vast majority of such timeout problems are on Windows for us.

I'll be satisfied if they pass, will re-evaluate if they fail.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ksunden

ksunden commented May 2, 2025

Copy link
Copy Markdown
Member

Hmmm... seems like we are continuing to get failures on the Azure Linux 3.11 build...

However, does not appear to be unique to this PR upon closer look at recent backports, so willing to merge over.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ksunden
ksunden merged commit 0595366 into matplotlib:v3.10.x May 2, 2025
@QuLogic
QuLogic deleted the auto-backport-of-pr-29827-on-v3.10.x branch May 3, 2025 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic: testing

Projects

None yet

Milestone

v3.10.3

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@QuLogic @dstansby @ksunden
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.