GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add type stubs for functions in matplotlib.dates by dstansby · Pull Request #30385 · matplotlib/matplotlib

Conversation

@dstansby

@dstansby dstansby commented Aug 3, 2025

Copy link
Copy Markdown
Member

PR summary

This is a start at tackling #26942. To keep the PR manageable, I've started with just the functions at the top of the file.

PR checklist

  • "closes #0000" is in the body of the PR description to link the related issue
  • new and changed code is tested
  • Plotting related features are demonstrated in an example
  • New Features and API Changes are noted with a directive and release note
  • Documentation complies with general and docstring guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@dstansby
Add type stubs for functions in matplotlib.dates
49c2869
@github-actions github-actions Bot added the topic: date handling label Aug 3, 2025
@dstansby dstansby added the topic: typing label Aug 3, 2025
timhoffm
timhoffm reviewed Aug 3, 2025
View reviewed changes
Comment thread lib/matplotlib/dates.pyi Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread lib/matplotlib/dates.pyi Resolved

Uh oh!

There was an error while loading. Please reload this page.
dstansby added 5 commits August 4, 2025 09:04
@dstansby
Make date typing tighter with overloads
ec0cdc4
@dstansby
Fix _dt64_to_ordinalf type
3976203
@dstansby
Remvoe old type alisas
636889f
@dstansby
Add argument defaults
1117e2f
@dstansby
Remove overload on datestr2num
d82075f
timhoffm
timhoffm approved these changes Aug 4, 2025
View reviewed changes
@QuLogic

QuLogic commented Aug 5, 2025

Copy link
Copy Markdown
Member

Note, this file was already done by a new contributor in #30126; would you be interested in tackling the final comments there instead?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dstansby dstansby mentioned this pull request Aug 12, 2025
Add type hints for matplotlib.dates module #30126
Draft
2 tasks done
@dstansby

dstansby commented Aug 23, 2025

Copy link
Copy Markdown
Member Author

Note, this file was already done by a new contributor in #30126; would you be interested in tackling the final comments there instead?

It looks like this PR is stalled, but I'd be happy to take it over. Do you have a preference on whether this PR should be merged or closed before I finish of the work in #30126? I'd have a soft preference to merge this since it's smaller and already has one approval.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dstansby dstansby added the status: needs review label Aug 28, 2025
@tacaswell tacaswell added this to the v3.11.0 milestone Apr 3, 2026
tacaswell
tacaswell approved these changes Apr 3, 2026
View reviewed changes
@tacaswell
tacaswell merged commit 04243ef into matplotlib:main Apr 3, 2026
@dstansby
dstansby deleted the date-stubs-functions branch April 3, 2026 21:52
@QuLogic QuLogic removed the status: needs review label Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tacaswell tacaswell tacaswell approved these changes
@timhoffm timhoffm timhoffm approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic: date handling topic: typing

Projects

None yet

Milestone

v3.11.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@dstansby @QuLogic @tacaswell @timhoffm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.