GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — TST: Remove redundant font tests by QuLogic · Pull Request #30513 · matplotlib/matplotlib

Conversation

@QuLogic

@QuLogic QuLogic commented Sep 4, 2025

Copy link
Copy Markdown
Member

PR summary

I extracted this out of #30512 because it was causing issues with the pre-loading of test images. I may update this as/when I find more redundant tests.

  • test_backend_ps::test_type3_font is covered by test_backend_ps::test_multi_font_type3
  • test_text::test_pdf_chars_beyond_bmp is covered by test_backend_pdf::test_multi_font_type3 and test_backend_pdf::test_multi_font_type42
  • test_text::test_pdf_kerning is covered by test_backend_pdf::test_kerning
  • test_text::test_pdf_type42_kerning is covered by test_backend_pdf::test_kerning

PR checklist

  • [n/a] "closes #0000" is in the body of the PR description to link the related issue
  • new and changed code is tested
  • [n/a] Plotting related features are demonstrated in an example
  • [n/a] New Features and API Changes are noted with a directive and release note
  • [n/a] Documentation complies with general and docstring guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@QuLogic QuLogic added this to the v3.11.0 milestone Sep 4, 2025
@QuLogic QuLogic added the status: waiting for other PR label Sep 4, 2025
@github-actions github-actions Bot added topic: text backend: ps backend: pdf backend: svg backend: cairo topic: text/mathtext status: needs rebase labels Sep 4, 2025
@QuLogic QuLogic added this to Font and text overhaul Jan 31, 2026
@github-project-automation github-project-automation Bot moved this to Waiting for other PR in Font and text overhaul Jan 31, 2026
@QuLogic
QuLogic force-pushed the redundant-font-tests branch from c9802ea to ec45d5f Compare January 31, 2026 09:22
@github-actions github-actions Bot removed topic: text backend: ps backend: pdf backend: svg backend: cairo topic: text/mathtext status: needs rebase labels Jan 31, 2026
@QuLogic QuLogic removed the status: waiting for other PR label Jan 31, 2026
@melissawm melissawm added topic: text/fonts topic: testing labels Jan 31, 2026
@QuLogic
QuLogic force-pushed the redundant-font-tests branch from ec45d5f to b7f089c Compare February 3, 2026 09:05
@github-actions github-actions Bot removed the topic: text/fonts label Feb 3, 2026
@QuLogic
TST: Remove redundant font tests
9d23373 
- `test_backend_ps::test_type3_font` is covered by
  `test_backend_ps::test_multi_font_type3`
- `test_text::test_pdf_chars_beyond_bmp` is covered by
  `test_backend_pdf::test_multi_font_type3` and
  `test_backend_pdf::test_multi_font_type42`
- `test_text::test_pdf_kerning` is covered by
  `test_backend_pdf::test_kerning`
- `test_text::test_pdf_type42_kerning` is covered by
  `test_backend_pdf::test_kerning`
@QuLogic
QuLogic force-pushed the redundant-font-tests branch from b7f089c to 9d23373 Compare March 2, 2026 15:49
@QuLogic
QuLogic marked this pull request as ready for review March 2, 2026 15:49
@QuLogic QuLogic moved this from Waiting for other PR to Ready for Review in Font and text overhaul Mar 2, 2026
@QuLogic

QuLogic commented Mar 2, 2026

Copy link
Copy Markdown
Member Author

Unfortunately, the pre-loading of images doesn't handle this side having deleted the image, but I think this PR can be confirmed to be okay by hand.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ksunden
ksunden approved these changes Mar 6, 2026
View reviewed changes
@QuLogic

QuLogic commented Mar 6, 2026

Copy link
Copy Markdown
Member Author

Since this may or may not cause conflicts with the preload, going to wait to merge this one until the last minute.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tacaswell
tacaswell approved these changes Mar 19, 2026
View reviewed changes
@QuLogic

QuLogic commented Mar 26, 2026

Copy link
Copy Markdown
Member Author

I ran some tests locally and there shouldn't be any conflicts with the image preloading, so long as it's rebased on top of this, so I'll merge it now.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@QuLogic
QuLogic merged commit 3a9a111 into matplotlib:text-overhaul Mar 26, 2026
21 of 33 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@github-project-automation github-project-automation Bot moved this from Ready for Review to Done in Font and text overhaul Mar 26, 2026
@QuLogic
QuLogic deleted the redundant-font-tests branch March 26, 2026 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tacaswell tacaswell tacaswell approved these changes
@ksunden ksunden ksunden approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic: testing

Projects

Font and text overhaul
Status: Done

Milestone

v3.11.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@QuLogic @tacaswell @ksunden @melissawm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.