GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Copy-edit the "fonts in pdf and postscript" table. by anntzer · Pull Request #30569 · matplotlib/matplotlib

Conversation

@anntzer

@anntzer anntzer commented Sep 16, 2025

Copy link
Copy Markdown
Contributor

Remove unnecessary info snippets e.g. re: fractal rendering (this isn't a table for font designers); merge Type 42 entry together with TrueType (they are essentially the same technology).

PR summary

PR checklist

  • "closes #0000" is in the body of the PR description to link the related issue
  • new and changed code is tested
  • Plotting related features are demonstrated in an example
  • New Features and API Changes are noted with a directive and release note
  • Documentation complies with general and docstring guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@anntzer anntzer added Documentation topic: text/fonts labels Sep 16, 2025
@github-actions github-actions Bot added Documentation: user guide files in galleries/users_explain or doc/users and removed topic: text/fonts labels Sep 16, 2025
@tacaswell tacaswell added this to the v3.11.0 milestone Sep 17, 2025
@tacaswell

tacaswell commented Sep 17, 2025

Copy link
Copy Markdown
Member

👍 modulo placating the linter .

I think we should go with adding a # noqa: E501 after the closing """ or exempt this whole file from the line length checks rather than forcing the table to fit.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@story645

story645 commented Sep 17, 2025

Copy link
Copy Markdown
Member

rather than forcing the table to fit.

Might be worth switching the table to a list-table since most of the sentences are long?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@anntzer

anntzer commented Sep 17, 2025

Copy link
Copy Markdown
Contributor Author

It would be nice if sphinx-gallery authorized this file to just be a .rst (which would get properly highlighted in the editor and not be subject to irrelevant python linting rules. (@timhoffm IIRC you interact a bit with the s-g team, perhaps you have an opinion there?)
In any case I'll just noqa this file for now.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@anntzer
Copy-edit the "fonts in pdf and postscript" table.
ec72aa0
Remove unnecessary info snippets e.g. re: fractal rendering (this isn't
a table for font designers); merge Type 42 entry together with TrueType
(they are essentially the same technology).
@anntzer
anntzer force-pushed the fd branch from e4db92d to ec72aa0 Compare September 17, 2025 13:38
QuLogic
QuLogic approved these changes Sep 18, 2025
View reviewed changes
@timhoffm

timhoffm commented Sep 18, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

It would be nice if sphinx-gallery authorized this file to just be a .rst (which would get properly highlighted in the editor and not be subject to irrelevant python linting rules. (@timhoffm IIRC you interact a bit with the s-g team, perhaps you have an opinion there?)

As of today sphinx-gallery does not support this (see https://sphinx-gallery.github.io/stable/syntax.html#plain-rest-examples). I'm not clear whether that's a fundamental design decision or whether it's just not implemented. Technically, that would be perfectly possible. It just slightly complicates the processing in that you have to skip the right parts of the example build.

What you could try as a workaround is making a placeholder .py file and include an .rst

"""
.. include:: actual_content.rst
"""

May need some fiddling to get the path to the rst file right.

Alternatively, just include the table as a separate .rst file or use a list table as suggested by @story645.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

timhoffm
timhoffm approved these changes Sep 18, 2025
View reviewed changes
@timhoffm
timhoffm merged commit 1377f24 into matplotlib:main Sep 18, 2025
@anntzer
anntzer deleted the fd branch September 18, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuLogic QuLogic QuLogic approved these changes
@timhoffm timhoffm timhoffm approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Documentation: user guide files in galleries/users_explain or doc/users Documentation

Projects

None yet

Milestone

v3.11.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@anntzer @tacaswell @story645 @timhoffm @QuLogic
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.