GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||||
GeezerVison is showing github.com — Switch from pre-commit to prek by QuLogic · Pull Request #31081 · matplotlib/matplotlib Conversation
Member
PR summaryFollowing the benchmarks from Hugo van Kemenade, we get about 3× faster with prek:
with hyperfine results of: These benchmarks were run on my desktop, which is several generations behind, but was more idle than my laptop. I would run on my laptop (which is still about 5 years old), but I don't really want to wait for hyperfine to do another long run like that. Since we aren't using pre-commit's CI anyway, it's easy to switch GitHub Actions directly. PR checklist
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Following the [benchmarks from Hugo van Kemenade](https://hugovk.dev/blog/2025/ready-prek-go/), we get about 3× faster with prek: | | pre-commit | prek | Ratio | | --------------- | ---------- | --------- | ----- | | run --all-files | 4m52.503s | 1m26.718s | 3.373 | | install-hooks | 3m31.002s | 1m6.608s | 3.168 | | hyperfine | 176.214 | 58.500 | 3.01 | with hyperfine results of: ``` Benchmark 1: prek install-hooks Time (mean ± σ): 58.500 s ± 15.029 s [User: 8.485 s, System: 3.138 s] Range (min … max): 30.766 s … 76.617 s 10 runs Benchmark 2: pre-commit install-hooks Time (mean ± σ): 176.214 s ± 11.544 s [User: 31.003 s, System: 5.127 s] Range (min … max): 161.969 s … 198.271 s 10 runs Summary prek install-hooks ran 3.01 ± 0.80 times faster than pre-commit install-hooks ```
Member
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
tacaswell
approved these changes
story645
approved these changes
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for updating the dev docs!
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
timhoffm
approved these changes
Member
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Member
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Member
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
greglucas
approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
Documentation: devdocs
ProjectsDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |||||||||||||||||||||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |