GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Clarify fonttype switch in backend_pdf. by anntzer · Pull Request #31456 · matplotlib/matplotlib

Conversation

@anntzer

@anntzer anntzer commented Apr 5, 2026

Copy link
Copy Markdown
Contributor

Make it clearer that switches are only over 3 possible fonttypes (1, 3, 42). In draw_text, the logic is easier to follow if one directly switches over rcParams['pdf.use14corefonts']; this requires putting the url handling at the end, which doesn't matter.

PR summary

AI Disclosure

PR checklist

  • "closes #0000" is in the body of the PR description to link the related issue
  • new and changed code is tested
  • Plotting related features are demonstrated in an example
  • New Features and API Changes are noted with a directive and release note
  • Documentation complies with general and docstring guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@github-actions github-actions Bot added the backend: pdf label Apr 5, 2026
timhoffm
timhoffm reviewed Apr 6, 2026
View reviewed changes
Comment thread lib/matplotlib/backends/backend_pdf.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread lib/matplotlib/backends/backend_pdf.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@anntzer
Clarify fonttype switch in backend_pdf.
dbf8c17 
Make it clearer that switches are only over 3 possible fonttypes (1, 3,
42).  In draw_text, the logic is easier to follow if one directly
switches over rcParams['pdf.use14corefonts']; this requires putting the
url handling at the end, which doesn't matter.
@anntzer
anntzer force-pushed the pdfft branch from fbf088b to dbf8c17 Compare April 6, 2026 21:31
timhoffm
timhoffm approved these changes Apr 6, 2026
View reviewed changes
QuLogic
QuLogic approved these changes Apr 6, 2026
View reviewed changes
@QuLogic QuLogic added this to the v3.11.0 milestone Apr 6, 2026
@QuLogic QuLogic closed this Apr 7, 2026
@QuLogic QuLogic reopened this Apr 7, 2026
@QuLogic
QuLogic merged commit 49bb098 into matplotlib:text-overhaul Apr 7, 2026
43 of 58 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@anntzer
anntzer deleted the pdfft branch April 7, 2026 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuLogic QuLogic QuLogic approved these changes
@timhoffm timhoffm timhoffm approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

backend: pdf

Projects

None yet

Milestone

v3.11.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@anntzer @QuLogic @timhoffm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.