GeezerVison is showing github.com — Support font features/language in default RendererBase.draw_text by QuLogic · Pull Request #31461 · matplotlib/matplotlib
Conversation
QuLogic
commented
Apr 7, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
PR summary
If a backend doesn't implement draw_text, then we fall back to this implementation that draws paths. It was previously missing support for font features and languages.
Unfortunately, there is currently no way to test this, as all our internal renderers override draw_text, and not using it would produce completely different images due to paths rendering differently than FreeType's images.
You can manually test this by renaming RendererAgg.draw_text and then running, e.g., pytest lib/matplotlib/tests/test_text.py -k 'language or feature'
I put together a test that does exactly that using monkey patching to ensure we use the fallback path.
AI Disclosure
None
PR checklist
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
If a backend doesn't implement `draw_text`, then we fall back to this
implementation that draws paths. It was previously missing support for
font features and languages.
This exercises complex shaping, font features, and language support.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
ksunden
ksunden approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.