GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Support font features/language in default RendererBase.draw_text by QuLogic · Pull Request #31461 · matplotlib/matplotlib

Conversation

@QuLogic

@QuLogic QuLogic commented Apr 7, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR summary

If a backend doesn't implement draw_text, then we fall back to this implementation that draws paths. It was previously missing support for font features and languages.

Unfortunately, there is currently no way to test this, as all our internal renderers override draw_text, and not using it would produce completely different images due to paths rendering differently than FreeType's images.

You can manually test this by renaming RendererAgg.draw_text and then running, e.g., pytest lib/matplotlib/tests/test_text.py -k 'language or feature'

I put together a test that does exactly that using monkey patching to ensure we use the fallback path.

AI Disclosure

None

PR checklist

  • [n/a] "closes #0000" is in the body of the PR description to link the related issue
  • new and changed code is tested
  • [n/a] Plotting related features are demonstrated in an example
  • [n/a] New Features and API Changes are noted with a directive and release note
  • [n/a] Documentation complies with general and docstring guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@QuLogic
Support font features/language in default RendererBase.draw_text
9059da7
If a backend doesn't implement `draw_text`, then we fall back to this
implementation that draws paths. It was previously missing support for
font features and languages.
@QuLogic QuLogic added this to the v3.11.0 milestone Apr 7, 2026
@QuLogic QuLogic added this to Font and text overhaul Apr 7, 2026
@github-project-automation github-project-automation Bot moved this to Waiting for other PR in Font and text overhaul Apr 7, 2026
@github-actions github-actions Bot added the topic: canvas and figure manager label Apr 7, 2026
@QuLogic
TST: Add a test for RendererBase.draw_text
4461ad7
This exercises complex shaping, font features, and language support.
@QuLogic
QuLogic force-pushed the default-features branch from 882d947 to 4461ad7 Compare April 7, 2026 08:02
@QuLogic QuLogic moved this from Waiting for other PR to Ready for Review in Font and text overhaul Apr 8, 2026
tacaswell
tacaswell approved these changes Apr 8, 2026
View reviewed changes
ksunden
ksunden approved these changes Apr 9, 2026
View reviewed changes
@ksunden
ksunden merged commit 8672cf9 into matplotlib:text-overhaul Apr 9, 2026
34 of 37 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@github-project-automation github-project-automation Bot moved this from Ready for Review to Done in Font and text overhaul Apr 9, 2026
@QuLogic
QuLogic deleted the default-features branch April 9, 2026 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tacaswell tacaswell tacaswell approved these changes
@ksunden ksunden ksunden approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic: canvas and figure manager

Projects

Font and text overhaul
Status: Done

Milestone

v3.11.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@QuLogic @tacaswell @ksunden
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.